From 049f5ef9b9bcc6b2dcf3fe353c2deb10a140e910 Mon Sep 17 00:00:00 2001 From: Peter Kasting Date: Tue, 14 Mar 2023 09:56:25 -0700 Subject: [PATCH] Always check out google_benchmark, part 4. Remove use of non-WebRTC-specific arg to control benchmark use. Bug: chromium:1404759 Change-Id: If50b215ff6c7698d385d1271bc8b6c38ed443e32 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/297680 Auto-Submit: Peter Kasting Commit-Queue: Mirko Bonadei Reviewed-by: Mirko Bonadei Cr-Commit-Position: refs/heads/main@{#39556} --- BUILD.gn | 2 +- rtc_base/BUILD.gn | 2 +- rtc_base/synchronization/BUILD.gn | 3 +-- test/BUILD.gn | 2 +- 4 files changed, 4 insertions(+), 5 deletions(-) diff --git a/BUILD.gn b/BUILD.gn index 24fe451725..d0e643ec6e 100644 --- a/BUILD.gn +++ b/BUILD.gn @@ -628,7 +628,7 @@ if (rtc_include_tests && !build_with_chromium) { } } - if (enable_google_benchmarks && rtc_enable_google_benchmarks) { + if (rtc_enable_google_benchmarks) { rtc_test("benchmarks") { testonly = true deps = [ diff --git a/rtc_base/BUILD.gn b/rtc_base/BUILD.gn index 4c860cd933..49aa930305 100644 --- a/rtc_base/BUILD.gn +++ b/rtc_base/BUILD.gn @@ -2041,7 +2041,7 @@ if (rtc_include_tests) { "synchronization:mutex", "third_party/sigslot", ] - if (enable_google_benchmarks && rtc_enable_google_benchmarks) { + if (rtc_enable_google_benchmarks) { deps += [ "synchronization:synchronization_unittests" ] } if (is_win) { diff --git a/rtc_base/synchronization/BUILD.gn b/rtc_base/synchronization/BUILD.gn index 5b2ff6e3e6..ce6965830f 100644 --- a/rtc_base/synchronization/BUILD.gn +++ b/rtc_base/synchronization/BUILD.gn @@ -73,8 +73,7 @@ rtc_library("yield_policy") { ] } -if (rtc_include_tests && enable_google_benchmarks && - rtc_enable_google_benchmarks) { +if (rtc_include_tests && rtc_enable_google_benchmarks) { rtc_library("synchronization_unittests") { testonly = true sources = [ diff --git a/test/BUILD.gn b/test/BUILD.gn index 79595ebdfd..a9b37bb7dd 100644 --- a/test/BUILD.gn +++ b/test/BUILD.gn @@ -495,7 +495,7 @@ rtc_library("video_test_support") { } if (rtc_include_tests) { - if (enable_google_benchmarks && rtc_enable_google_benchmarks) { + if (rtc_enable_google_benchmarks) { rtc_library("benchmark_main") { testonly = true sources = [ "benchmark_main.cc" ]