From 187c6992fbf68c84c1841a8320d94a42c486c7f1 Mon Sep 17 00:00:00 2001 From: Alex Loiko Date: Fri, 27 Oct 2017 16:21:31 +0200 Subject: [PATCH] Replacing undefined left shifts with multiplication. Issue was found by the Audio Processing fuzzer. Bug: chromium:778939, chromium:778921, chromium:778919 Change-Id: If613cf4c533f546d118f10a6358cecd329958177 Reviewed-on: https://webrtc-review.googlesource.com/16161 Commit-Queue: Alex Loiko Reviewed-by: Karl Wiberg Cr-Commit-Position: refs/heads/master@{#20494} --- common_audio/signal_processing/resample_by_2.c | 2 +- common_audio/vad/vad_core.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/common_audio/signal_processing/resample_by_2.c b/common_audio/signal_processing/resample_by_2.c index 92c613fdb0..73e1950654 100644 --- a/common_audio/signal_processing/resample_by_2.c +++ b/common_audio/signal_processing/resample_by_2.c @@ -141,7 +141,7 @@ void WebRtcSpl_UpsampleBy2(const int16_t* in, size_t len, for (i = len; i > 0; i--) { // lower allpass filter - in32 = (int32_t)(*in++) << 10; + in32 = (int32_t)(*in++) * (1 << 10); diff = in32 - state1; tmp1 = MUL_ACCUM_1(kResampleAllpass1[0], diff, state0); state0 = in32; diff --git a/common_audio/vad/vad_core.c b/common_audio/vad/vad_core.c index 4085443bfc..7316b45ce8 100644 --- a/common_audio/vad/vad_core.c +++ b/common_audio/vad/vad_core.c @@ -241,7 +241,7 @@ static int16_t GmmProbability(VadInstT* self, int16_t* features, (int32_t) (log_likelihood_ratio * kSpectrumWeight[channel]); // Local VAD decision. - if ((log_likelihood_ratio << 2) > individualTest) { + if ((log_likelihood_ratio * 4) > individualTest) { vadflag = 1; }