From 199fd755bd585adcf352f8308026290779ea21ae Mon Sep 17 00:00:00 2001 From: Jeremy Leconte Date: Fri, 12 Jan 2024 16:28:18 +0100 Subject: [PATCH] Run video_codec_perf_tests using the quick mode on Android try bots. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Change-Id: I02678b033815f843e4aee1585ef64c4d9b7e7b14 Bug: None Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/334220 Reviewed-by: Sergey Silkin Reviewed-by: Jeremy Leconte Reviewed-by: Erik Språng Commit-Queue: Jeremy Leconte Cr-Commit-Position: refs/heads/main@{#41535} --- infra/specs/test_suites.pyl | 3 + infra/specs/tryserver.webrtc.json | 100 ++++++++++++++++++ .../codecs/test/video_codec_test.cc | 10 +- 3 files changed, 108 insertions(+), 5 deletions(-) diff --git a/infra/specs/test_suites.pyl b/infra/specs/test_suites.pyl index 23251842e3..e6d98748c7 100644 --- a/infra/specs/test_suites.pyl +++ b/infra/specs/test_suites.pyl @@ -54,6 +54,9 @@ 'webrtc_nonparallel_tests': {}, }, 'android_tests_tryserver_specific': { + 'video_codec_perf_tests': { + 'mixins': ['shards-2', 'quick-perf-tests'], + }, 'webrtc_perf_tests': { 'mixins': ['quick-perf-tests'], } diff --git a/infra/specs/tryserver.webrtc.json b/infra/specs/tryserver.webrtc.json index e4b9e254f3..3ab538b02c 100644 --- a/infra/specs/tryserver.webrtc.json +++ b/infra/specs/tryserver.webrtc.json @@ -368,6 +368,31 @@ "test": "tools_unittests", "test_id_prefix": "ninja://rtc_tools:tools_unittests/" }, + { + "args": [ + "--webrtc_quick_perf_test", + "--nologs" + ], + "merge": { + "script": "//testing/merge_scripts/standard_gtest_merge.py" + }, + "name": "video_codec_perf_tests", + "resultdb": { + "enable": true, + "has_native_resultdb_integration": true + }, + "swarming": { + "dimensions": { + "android_devices": "1", + "device_type": "walleye", + "os": "Android" + }, + "service_account": "chromium-tester@chops-service-accounts.iam.gserviceaccount.com", + "shards": 2 + }, + "test": "video_codec_perf_tests", + "test_id_prefix": "ninja://modules/video_coding:video_codec_perf_tests/" + }, { "merge": { "script": "//testing/merge_scripts/standard_gtest_merge.py" @@ -845,6 +870,31 @@ "test": "tools_unittests", "test_id_prefix": "ninja://rtc_tools:tools_unittests/" }, + { + "args": [ + "--webrtc_quick_perf_test", + "--nologs" + ], + "merge": { + "script": "//testing/merge_scripts/standard_gtest_merge.py" + }, + "name": "video_codec_perf_tests", + "resultdb": { + "enable": true, + "has_native_resultdb_integration": true + }, + "swarming": { + "dimensions": { + "android_devices": "1", + "device_type": "walleye", + "os": "Android" + }, + "service_account": "chromium-tester@chops-service-accounts.iam.gserviceaccount.com", + "shards": 2 + }, + "test": "video_codec_perf_tests", + "test_id_prefix": "ninja://modules/video_coding:video_codec_perf_tests/" + }, { "merge": { "script": "//testing/merge_scripts/standard_gtest_merge.py" @@ -1322,6 +1372,31 @@ "test": "tools_unittests", "test_id_prefix": "ninja://rtc_tools:tools_unittests/" }, + { + "args": [ + "--webrtc_quick_perf_test", + "--nologs" + ], + "merge": { + "script": "//testing/merge_scripts/standard_gtest_merge.py" + }, + "name": "video_codec_perf_tests", + "resultdb": { + "enable": true, + "has_native_resultdb_integration": true + }, + "swarming": { + "dimensions": { + "android_devices": "1", + "device_type": "walleye", + "os": "Android" + }, + "service_account": "chromium-tester@chops-service-accounts.iam.gserviceaccount.com", + "shards": 2 + }, + "test": "video_codec_perf_tests", + "test_id_prefix": "ninja://modules/video_coding:video_codec_perf_tests/" + }, { "merge": { "script": "//testing/merge_scripts/standard_gtest_merge.py" @@ -1824,6 +1899,31 @@ "test": "tools_unittests", "test_id_prefix": "ninja://rtc_tools:tools_unittests/" }, + { + "args": [ + "--webrtc_quick_perf_test", + "--nologs" + ], + "merge": { + "script": "//testing/merge_scripts/standard_gtest_merge.py" + }, + "name": "video_codec_perf_tests", + "resultdb": { + "enable": true, + "has_native_resultdb_integration": true + }, + "swarming": { + "dimensions": { + "android_devices": "1", + "device_type": "walleye", + "os": "Android" + }, + "service_account": "chromium-tester@chops-service-accounts.iam.gserviceaccount.com", + "shards": 2 + }, + "test": "video_codec_perf_tests", + "test_id_prefix": "ninja://modules/video_coding:video_codec_perf_tests/" + }, { "merge": { "script": "//testing/merge_scripts/standard_gtest_merge.py" diff --git a/modules/video_coding/codecs/test/video_codec_test.cc b/modules/video_coding/codecs/test/video_codec_test.cc index 60c2fcbb6e..6aa2562065 100644 --- a/modules/video_coding/codecs/test/video_codec_test.cc +++ b/modules/video_coding/codecs/test/video_codec_test.cc @@ -348,15 +348,15 @@ INSTANTIATE_TEST_SUITE_P( Values("builtin"), #endif Values(kRawVideos.at("FourPeople_1280x720_30")), - Values(std::make_tuple(320, 180, 30, 32, 28), - std::make_tuple(320, 180, 30, 64, 30), - std::make_tuple(320, 180, 30, 128, 33), + Values(std::make_tuple(320, 180, 30, 32, 26), + std::make_tuple(320, 180, 30, 64, 29), + std::make_tuple(320, 180, 30, 128, 32), std::make_tuple(320, 180, 30, 256, 36), - std::make_tuple(640, 360, 30, 128, 31), + std::make_tuple(640, 360, 30, 128, 29), std::make_tuple(640, 360, 30, 256, 33), std::make_tuple(640, 360, 30, 384, 35), std::make_tuple(640, 360, 30, 512, 36), - std::make_tuple(1280, 720, 30, 256, 32), + std::make_tuple(1280, 720, 30, 256, 30), std::make_tuple(1280, 720, 30, 512, 34), std::make_tuple(1280, 720, 30, 1024, 37), std::make_tuple(1280, 720, 30, 2048, 39))),