From 1d20185afd396b9e1cd0328d6f479fa023e7bf89 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Niels=20M=C3=B6ller?= Date: Wed, 26 Jun 2019 12:58:27 +0200 Subject: [PATCH] Convert file objects to strings, before passing to PresubmitNotifyResult Json support, added in https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1666250, breaks with object which aren't serializable. Bug: chromium:971895 Change-Id: I36be5a548f8b82d4969fb38c34521e8df1a0b4c2 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/143882 Reviewed-by: Oleh Prypin Reviewed-by: Karl Wiberg Commit-Queue: Niels Moller Cr-Commit-Position: refs/heads/master@{#28384} --- PRESUBMIT.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/PRESUBMIT.py b/PRESUBMIT.py index 7c423c8666..2e3abc3165 100755 --- a/PRESUBMIT.py +++ b/PRESUBMIT.py @@ -175,11 +175,11 @@ def CheckNativeApiHeaderChanges(input_api, output_api): if path == 'api': # Special case: Subdirectories included. if dn == 'api' or dn.startswith('api/'): - files.append(f) + files.append(f.LocalPath()) else: # Normal case: Subdirectories not included. if dn == path: - files.append(f) + files.append(f.LocalPath()) if files: return [output_api.PresubmitNotifyResult(API_CHANGE_MSG, files)]