From 2491dbdf0b59cc080ea7218c32c109f4c8b304fe Mon Sep 17 00:00:00 2001 From: Paul Hallak Date: Fri, 21 May 2021 07:31:52 +0200 Subject: [PATCH] Make Clock::ConvertTimestampToNtpTime pure virtual No-Try because of lack of infra lack of capacity on macs. No-Try: True Bug: webrtc:11327 Change-Id: I9296bb92fdd62800da3ddd80789164c80350577d Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/219782 Commit-Queue: Paul Hallak Reviewed-by: Niels Moller Cr-Commit-Position: refs/heads/master@{#34073} --- system_wrappers/include/clock.h | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/system_wrappers/include/clock.h b/system_wrappers/include/clock.h index 62d2216d9f..271291c214 100644 --- a/system_wrappers/include/clock.h +++ b/system_wrappers/include/clock.h @@ -47,11 +47,7 @@ class RTC_EXPORT Clock { int64_t CurrentNtpInMilliseconds() { return CurrentNtpTime().ToMs(); } // Converts between a relative timestamp returned by this clock, to NTP time. - // TODO(bugs.webrtc.org/11327): Make this method pure virtual, - // and delete default dummy implementation. - virtual NtpTime ConvertTimestampToNtpTime(Timestamp timestamp) { - return NtpTime(); - } + virtual NtpTime ConvertTimestampToNtpTime(Timestamp timestamp) = 0; int64_t ConvertTimestampToNtpTimeInMilliseconds(int64_t timestamp_ms) { return ConvertTimestampToNtpTime(Timestamp::Millis(timestamp_ms)).ToMs(); }