From 2cc99f154455b5973687758dfa58e95a87e6a04e Mon Sep 17 00:00:00 2001 From: Jeremy Leconte Date: Wed, 6 Nov 2024 10:26:33 +0100 Subject: [PATCH] Disable use_fuzztest_wrapper for bots not using libfuzzer. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This is to avoid a dependency on Chromium //base on bots that don't need it: https://source.chromium.org/chromium/_/chromium/chromium/src/testing/+/1bd0da6657e330cf26ed0702b3f456393587ad7c:libfuzzer/BUILD.gn;l=164 Bug: None Change-Id: Idf3ef2a313641abcd3741e0ef7b2fac61c629068 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/367640 Commit-Queue: Jeremy Leconte Reviewed-by: Björn Terelius Cr-Commit-Position: refs/heads/main@{#43360} --- .gn | 3 +++ tools_webrtc/mb/mb_config.pyl | 3 ++- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/.gn b/.gn index 8928cdbaaf..f4c26795a0 100644 --- a/.gn +++ b/.gn @@ -81,4 +81,7 @@ default_args = { # WebRTC doesn't use jni_zero's multiplexing. Since this causes an error # let's temporarily disable it. enable_jni_multiplexing = false + + # This adds a dependency to //base. + use_fuzztest_wrapper = false } diff --git a/tools_webrtc/mb/mb_config.pyl b/tools_webrtc/mb/mb_config.pyl index f66a6096f8..d148ddc811 100644 --- a/tools_webrtc/mb/mb_config.pyl +++ b/tools_webrtc/mb/mb_config.pyl @@ -484,7 +484,8 @@ 'gn_args': 'ios_code_signing_identity_description="Apple Development"', }, 'libfuzzer': { - 'gn_args': 'use_libfuzzer=true', + # use_fuzztest_wrapper adds a dependency to //base. + 'gn_args': 'use_libfuzzer=true use_fuzztest_wrapper=true', }, 'lsan': { 'gn_args': 'is_lsan=true',