From 2eb465fc7b9c36e981973d0b2ea1d29c3d28d95d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Niels=20M=C3=B6ller?= Date: Mon, 23 Aug 2021 11:17:56 +0200 Subject: [PATCH] Log error on ssltcp failures (fake ssl handshake) Followup to https://webrtc-review.googlesource.com/c/src/+/229384. Bug: None Change-Id: I9d0a4f29514b5699f90e9a8af1457a7b68de3bd0 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/229586 Reviewed-by: Taylor Brandstetter Reviewed-by: Harald Alvestrand Commit-Queue: Niels Moller Cr-Commit-Position: refs/heads/main@{#34833} --- rtc_base/socket_adapters.cc | 2 ++ 1 file changed, 2 insertions(+) diff --git a/rtc_base/socket_adapters.cc b/rtc_base/socket_adapters.cc index cc541a42c6..ee8ec877cd 100644 --- a/rtc_base/socket_adapters.cc +++ b/rtc_base/socket_adapters.cc @@ -183,6 +183,7 @@ void AsyncSSLSocket::OnConnectEvent(Socket* socket) { // TODO: we could buffer output too... const int res = DirectSend(kSslClientHello, sizeof(kSslClientHello)); if (res != sizeof(kSslClientHello)) { + RTC_LOG(LS_ERROR) << "Sending fake SSL ClientHello message failed."; Close(); SignalCloseEvent(this, 0); } @@ -193,6 +194,7 @@ void AsyncSSLSocket::ProcessInput(char* data, size_t* len) { return; if (memcmp(kSslServerHello, data, sizeof(kSslServerHello)) != 0) { + RTC_LOG(LS_ERROR) << "Received non-matching fake SSL ServerHello message."; Close(); SignalCloseEvent(this, 0); // TODO: error code? return;