From 47126fa5369eac0e54c166a7f68fbbd4bbc6c7e4 Mon Sep 17 00:00:00 2001 From: Peter Kasting Date: Tue, 28 Sep 2021 10:08:54 -0700 Subject: [PATCH] Force -Wno-shadow to avoid variable shadowing warnings. Long term, ideally, these would be fixed and this flag can be removed. For now, this is an expedient way to allow enabling -Wshadow in Chromium. Bug: chromium:794619 Change-Id: I7aba1c7bb7dfe0598cdb077cb97def752b8bac79 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/232660 Commit-Queue: Peter Kasting Reviewed-by: Mirko Bonadei Cr-Commit-Position: refs/heads/main@{#35110} --- BUILD.gn | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/BUILD.gn b/BUILD.gn index 314e7a6165..1a90c4bfa7 100644 --- a/BUILD.gn +++ b/BUILD.gn @@ -305,7 +305,10 @@ config("common_config") { defines += [ "WEBRTC_EXCLUDE_AUDIO_PROCESSING_MODULE" ] } - cflags = [] + # TODO(webrtc:13219): Fix -Wshadow instances and enable. + if (is_clang) { + cflags += [ "-Wno-shadow" ] + } if (build_with_chromium) { defines += [