From 523b67d69bd8aa8b683dd50cfe0701ffe0179499 Mon Sep 17 00:00:00 2001 From: Florent Castelli Date: Wed, 22 Jun 2022 20:45:05 +0200 Subject: [PATCH] Use the condensed library name when fixing "foo:foo" dependencies The styleguide prefers using condensed library nam "foo" instead of "foo:foo" whenever possible. The script would address absolute and relative paths in other directories but not the ones in the current directory. Bug: None Change-Id: Ibc7850cd26edfe8fb864ce5baa2f460a95a7c96d Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/266489 Commit-Queue: Florent Castelli Reviewed-by: Mirko Bonadei Cr-Commit-Position: refs/heads/main@{#37315} --- tools_webrtc/gn_check_autofix.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools_webrtc/gn_check_autofix.py b/tools_webrtc/gn_check_autofix.py index 3895dc9abe..c68e370037 100644 --- a/tools_webrtc/gn_check_autofix.py +++ b/tools_webrtc/gn_check_autofix.py @@ -180,6 +180,8 @@ def main(): dep = Rebase(path, dep_path, dep) # Replacing /target:target with /target dep = re.sub(r'/(\w+):(\1)$', r'/\1', dep) + # Replacing target:target with target + dep = re.sub(r'^(\w+):(\1)$', r'\1', dep) path = os.path.join(path[2:], 'BUILD.gn') errors_by_file[path][target].add(dep) elif error[index + 1] == 'has a source file:':