From 55afe3885b9bbffce470f76af599d0deebd52eaa Mon Sep 17 00:00:00 2001 From: Magnus Flodman Date: Fri, 12 Jun 2020 14:55:40 +0200 Subject: [PATCH] Search and replace gendered terms according to style guide: https://chromium.googlesource.com/chromium/src/+/master/styleguide/inclusive_code.md#tools Not changin the transcipt in resources/audio_processing/conversational_speech/README.md BUG=webrtc:11680 Change-Id: I36af34e4a4e0ec6161093c0045b7bbe1dbe4eb45 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/177016 Reviewed-by: Tommi Cr-Commit-Position: refs/heads/master@{#31514} --- docs/faq.md | 4 ++-- .../androidapp/src/org/appspot/apprtc/AppRTCAudioManager.java | 4 ++-- logging/rtc_event_log/encoder/blob_encoding.h | 2 +- modules/rtp_rtcp/source/rtcp_receiver_unittest.cc | 2 +- modules/rtp_rtcp/source/rtcp_transceiver_config.h | 4 ++-- p2p/base/p2p_transport_channel_unittest.cc | 4 ++-- rtc_base/checks.h | 2 +- test/pc/e2e/analyzer/video/quality_analyzing_video_decoder.h | 4 ++-- test/pc/e2e/analyzer/video/quality_analyzing_video_encoder.h | 4 ++-- 9 files changed, 15 insertions(+), 15 deletions(-) diff --git a/docs/faq.md b/docs/faq.md index ed9143812a..9f31f31ee4 100644 --- a/docs/faq.md +++ b/docs/faq.md @@ -231,7 +231,7 @@ Yes, you still have the right to redistribute and you still have a patent license for Google's patents that cover the code that Google released. -### What if my competitor uses the code and brings patent litigation against me for something unrelated to the code. Does he or she still have a patent license? +### What if my competitor uses the code and brings patent litigation against me for something unrelated to the code. Do they still have a patent license? -Yes, he/she still has the right to redistribute and he/she still has a patent +Yes, they still have the right to redistribute and they still have a patent license for Google's patents that cover the code that Google released. diff --git a/examples/androidapp/src/org/appspot/apprtc/AppRTCAudioManager.java b/examples/androidapp/src/org/appspot/apprtc/AppRTCAudioManager.java index 7ae3d838dd..c32ab964ad 100644 --- a/examples/androidapp/src/org/appspot/apprtc/AppRTCAudioManager.java +++ b/examples/androidapp/src/org/appspot/apprtc/AppRTCAudioManager.java @@ -185,8 +185,8 @@ public class AppRTCAudioManager { // Note that, the sensor will not be active until start() has been called. proximitySensor = AppRTCProximitySensor.create(context, // This method will be called each time a state change is detected. - // Example: user holds his hand over the device (closer than ~5 cm), - // or removes his hand from the device. + // Example: user holds their hand over the device (closer than ~5 cm), + // or removes their hand from the device. this ::onProximitySensorChangedState); Log.d(TAG, "defaultAudioDevice: " + defaultAudioDevice); diff --git a/logging/rtc_event_log/encoder/blob_encoding.h b/logging/rtc_event_log/encoder/blob_encoding.h index 4a38dc5d0b..b5b589aaf6 100644 --- a/logging/rtc_event_log/encoder/blob_encoding.h +++ b/logging/rtc_event_log/encoder/blob_encoding.h @@ -43,7 +43,7 @@ namespace webrtc { // // Note that the returned std::string might have been reserved for significantly // more memory than it ends up using. If the caller to EncodeBlobs() intends -// to store the result long-term, he should consider shrink_to_fit()-ing it. +// to store the result long-term, they should consider shrink_to_fit()-ing it. std::string EncodeBlobs(const std::vector& blobs); std::vector DecodeBlobs(absl::string_view encoded_blobs, size_t num_of_blobs); diff --git a/modules/rtp_rtcp/source/rtcp_receiver_unittest.cc b/modules/rtp_rtcp/source/rtcp_receiver_unittest.cc index 960f8d3ea2..a384d71913 100644 --- a/modules/rtp_rtcp/source/rtcp_receiver_unittest.cc +++ b/modules/rtp_rtcp/source/rtcp_receiver_unittest.cc @@ -230,7 +230,7 @@ TEST(RtcpReceiverTest, InjectSrPacketFromUnknownSender) { rtcp::SenderReport sr; sr.SetSenderSsrc(kUnknownSenderSsrc); - // The parser will handle report blocks in Sender Report from other than his + // The parser will handle report blocks in Sender Report from other than their // expected peer. EXPECT_CALL(mocks.rtp_rtcp_impl, OnReceivedRtcpReportBlocks); EXPECT_CALL(mocks.bandwidth_observer, diff --git a/modules/rtp_rtcp/source/rtcp_transceiver_config.h b/modules/rtp_rtcp/source/rtcp_transceiver_config.h index 2cbd1045d2..8a8fd6aed8 100644 --- a/modules/rtp_rtcp/source/rtcp_transceiver_config.h +++ b/modules/rtp_rtcp/source/rtcp_transceiver_config.h @@ -28,8 +28,8 @@ class MediaReceiverRtcpObserver { public: virtual ~MediaReceiverRtcpObserver() = default; - // All message handlers have default empty implementation. This way user needs - // to implement only those she is interested in. + // All message handlers have default empty implementation. This way users only + // need to implement the ones they are interested in. virtual void OnSenderReport(uint32_t sender_ssrc, NtpTime ntp_time, uint32_t rtp_time) {} diff --git a/p2p/base/p2p_transport_channel_unittest.cc b/p2p/base/p2p_transport_channel_unittest.cc index eee91465be..523e9e8bc6 100644 --- a/p2p/base/p2p_transport_channel_unittest.cc +++ b/p2p/base/p2p_transport_channel_unittest.cc @@ -1480,7 +1480,7 @@ TEST_F(P2PTransportChannelTest, PeerReflexiveCandidateBeforeSignaling) { PauseCandidates(1); // Wait until the callee becomes writable to make sure that a ping request is - // received by the caller before his remote ICE credentials are set. + // received by the caller before their remote ICE credentials are set. ASSERT_TRUE_WAIT(ep2_ch1()->selected_connection() != nullptr, kMediumTimeout); // Add two sets of remote ICE credentials, so that the ones used by the // candidate will be generation 1 instead of 0. @@ -1588,7 +1588,7 @@ TEST_F(P2PTransportChannelTest, PeerReflexiveCandidateBeforeSignalingWithNAT) { PauseCandidates(1); // Wait until the callee becomes writable to make sure that a ping request is - // received by the caller before his remote ICE credentials are set. + // received by the caller before their remote ICE credentials are set. ASSERT_TRUE_WAIT(ep2_ch1()->selected_connection() != nullptr, kMediumTimeout); // Add two sets of remote ICE credentials, so that the ones used by the // candidate will be generation 1 instead of 0. diff --git a/rtc_base/checks.h b/rtc_base/checks.h index 2fde3f6640..61c074ac82 100644 --- a/rtc_base/checks.h +++ b/rtc_base/checks.h @@ -69,7 +69,7 @@ RTC_NORETURN void rtc_FatalMessage(const char* file, int line, const char* msg); // the reason that it's better to terminate might simply be that the error // handling code isn't in place yet; in production, the reason might be that // the author of the code truly believes that x will always be true, but that -// she recognizes that if she is wrong, abrupt and unpleasant process +// they recognizes that if they are wrong, abrupt and unpleasant process // termination is still better than carrying on with the assumption violated. // // RTC_CHECK always evaluates its argument, so it's OK for x to have side diff --git a/test/pc/e2e/analyzer/video/quality_analyzing_video_decoder.h b/test/pc/e2e/analyzer/video/quality_analyzing_video_decoder.h index 29fff1832e..decb844bc2 100644 --- a/test/pc/e2e/analyzer/video/quality_analyzing_video_decoder.h +++ b/test/pc/e2e/analyzer/video/quality_analyzing_video_decoder.h @@ -46,8 +46,8 @@ namespace webrtc_pc_e2e { // callback, where video analyzer will be called again and then decoded frame // will be passed to origin callback, provided by user. // -// Quality decoder registers its own callback in origin decoder at the same -// time, when user registers his callback in quality decoder. +// Quality decoder registers its own callback in origin decoder, at the same +// time the user registers their callback in quality decoder. class QualityAnalyzingVideoDecoder : public VideoDecoder { public: // Creates analyzing decoder. |id| is unique coding entity id, that will diff --git a/test/pc/e2e/analyzer/video/quality_analyzing_video_encoder.h b/test/pc/e2e/analyzer/video/quality_analyzing_video_encoder.h index fe9e6bb13c..f6db1369b0 100644 --- a/test/pc/e2e/analyzer/video/quality_analyzing_video_encoder.h +++ b/test/pc/e2e/analyzer/video/quality_analyzing_video_encoder.h @@ -50,8 +50,8 @@ constexpr int kAnalyzeAnySpatialStream = -1; // injected into EncodedImage with passed EncodedImageDataInjector. Then new // EncodedImage will be passed to origin callback, provided by user. // -// Quality encoder registers its own callback in origin encoder at the same -// time, when user registers his callback in quality encoder. +// Quality encoder registers its own callback in origin encoder, at the same +// time the user registers their callback in quality encoder. class QualityAnalyzingVideoEncoder : public VideoEncoder, public EncodedImageCallback { public: