From 5f96daa8a5a6e4a548e8fda763d9060d7771efb7 Mon Sep 17 00:00:00 2001 From: Alexander Schulze Date: Mon, 25 Apr 2022 13:17:10 +0200 Subject: [PATCH] [lkgr_finder] Toggle allowed_lag and allowed_gap It seems like this got confused when initially added [1,2]. The confusion affects the lag check [3], which only send an email in the past, but will raise a builder failure after [4] landed if there is a gap for more than 4 commits. [1] https://crsrc.org/i/infra/services/lkgr_finder/config/default_cfg.pyl?q=allowed_gap [2] https://crsrc.org/i/infra/services/lkgr_finder/test/lkgr_lib_test.py?q=allowed_gap [3] https://crsrc.org/i/infra/services/lkgr_finder/lkgr_lib.py;l=500?q=allowed_lag [4] https://crrev.com/c/3599253 Bug: chromium:1317669 Change-Id: I23726957439b03dced0fc0038ee65a3108f88fea Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/259874 Auto-Submit: Alex Schulze Reviewed-by: Christoffer Jansson Commit-Queue: Christoffer Jansson Cr-Commit-Position: refs/heads/main@{#36642} --- infra/config/config.star | 4 ++-- infra/config/cr-buildbucket.cfg | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/infra/config/config.star b/infra/config/config.star index cc71e1ec50..64923b090a 100755 --- a/infra/config/config.star +++ b/infra/config/config.star @@ -821,8 +821,8 @@ lkgr_config = { "project": "webrtc", "source_url": WEBRTC_GIT, "status_url": "https://webrtc-status.appspot.com", - "allowed_lag": 150, # hours - "allowed_gap": 4, # commits behind + "allowed_lag": 4, # hours (up to 10x during low commit volume periods) + "allowed_gap": 150, # commits behind "error_recipients": WEBRTC_TROOPER_EMAIL, "buckets": { "webrtc/ci": { diff --git a/infra/config/cr-buildbucket.cfg b/infra/config/cr-buildbucket.cfg index 1be58239fc..08619c449a 100644 --- a/infra/config/cr-buildbucket.cfg +++ b/infra/config/cr-buildbucket.cfg @@ -2002,8 +2002,8 @@ buckets { ' ]' ' },' ' "config": {' - ' "allowed_gap": 4,' - ' "allowed_lag": 150,' + ' "allowed_gap": 150,' + ' "allowed_lag": 4,' ' "buckets": {' ' "chromium/webrtc.fyi": {' ' "builders": ['