From 866d3373d7140e0c061c7e220184a4f87e19215f Mon Sep 17 00:00:00 2001 From: Mirko Bonadei Date: Fri, 15 Sep 2017 12:35:26 +0200 Subject: [PATCH] Re-enabling CheckOrphanHeaders NOTRY=True Bug: chromium:611808 Change-Id: I354ebe340a0cf70be8cd08b88adbb0f767070e1e Reviewed-on: https://webrtc-review.googlesource.com/1574 Reviewed-by: Henrik Kjellander Commit-Queue: Mirko Bonadei Cr-Commit-Position: refs/heads/master@{#19853} --- PRESUBMIT.py | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/PRESUBMIT.py b/PRESUBMIT.py index 66d6892634..fcac22fe8b 100755 --- a/PRESUBMIT.py +++ b/PRESUBMIT.py @@ -619,10 +619,7 @@ def CommonChecks(input_api, output_api): results.extend(CheckJSONParseErrors(input_api, output_api)) results.extend(RunPythonTests(input_api, output_api)) results.extend(CheckUsageOfGoogleProtobufNamespace(input_api, output_api)) - # TODO(mbonadei): re-enable after the migration from src/webrtc to src/ - # in order to avoid to trigger an error for each orphan header (we are - # moving all of them). - # results.extend(CheckOrphanHeaders(input_api, output_api)) + results.extend(CheckOrphanHeaders(input_api, output_api)) # TODO(mbonadei): check before re-enable because it seems it is reporting # some false positives. # results.extend(CheckNewLineAtTheEndOfProtoFiles(input_api, output_api))