diff --git a/api/peer_connection_interface.h b/api/peer_connection_interface.h index 4349d6bb3c..d280b30ada 100644 --- a/api/peer_connection_interface.h +++ b/api/peer_connection_interface.h @@ -1041,15 +1041,17 @@ class RTC_EXPORT PeerConnectionInterface : public webrtc::RefCountInterface { // The observer is invoked as soon as the operation completes, which could be // before or after the SetLocalDescription() method has exited. virtual void SetLocalDescription( - std::unique_ptr desc, - rtc::scoped_refptr observer) {} + std::unique_ptr /* desc */, + rtc::scoped_refptr /* observer */) { + } // Creates an offer or answer (depending on current signaling state) and sets // it as the local session description. // // The observer is invoked as soon as the operation completes, which could be // before or after the SetLocalDescription() method has exited. virtual void SetLocalDescription( - rtc::scoped_refptr observer) {} + rtc::scoped_refptr /* observer */) { + } // Like SetLocalDescription() above, but the observer is invoked with a delay // after the operation completes. This helps avoid recursive calls by the // observer but also makes it possible for states to change in-between the @@ -1059,7 +1061,8 @@ class RTC_EXPORT PeerConnectionInterface : public webrtc::RefCountInterface { // ones taking SetLocalDescriptionObserverInterface as argument. virtual void SetLocalDescription(SetSessionDescriptionObserver* observer, SessionDescriptionInterface* desc) = 0; - virtual void SetLocalDescription(SetSessionDescriptionObserver* observer) {} + virtual void SetLocalDescription( + SetSessionDescriptionObserver* /* observer */) {} // Sets the remote session description. // @@ -1078,8 +1081,9 @@ class RTC_EXPORT PeerConnectionInterface : public webrtc::RefCountInterface { // for synchronizing peer connection states to the application. // TODO(https://crbug.com/webrtc/11798): Delete this method in favor of the // ones taking SetRemoteDescriptionObserverInterface as argument. - virtual void SetRemoteDescription(SetSessionDescriptionObserver* observer, - SessionDescriptionInterface* desc) {} + virtual void SetRemoteDescription( + SetSessionDescriptionObserver* /* observer */, + SessionDescriptionInterface* /* desc */) {} // According to spec, we must only fire "negotiationneeded" if the Operations // Chain is empty. This method takes care of validating an event previously @@ -1124,8 +1128,9 @@ class RTC_EXPORT PeerConnectionInterface : public webrtc::RefCountInterface { virtual bool AddIceCandidate(const IceCandidateInterface* candidate) = 0; // TODO(hbos): Remove default implementation once implemented by downstream // projects. - virtual void AddIceCandidate(std::unique_ptr candidate, - std::function callback) {} + virtual void AddIceCandidate( + std::unique_ptr /* candidate */, + std::function /* callback */) {} // Removes a group of remote candidates from the ICE agent. Needed mainly for // continual gathering, to avoid an ever-growing list of candidates as diff --git a/api/test/video_quality_analyzer_interface.h b/api/test/video_quality_analyzer_interface.h index c9b7851ab0..b8c510262e 100644 --- a/api/test/video_quality_analyzer_interface.h +++ b/api/test/video_quality_analyzer_interface.h @@ -127,45 +127,47 @@ class VideoQualityAnalyzerInterface // Will be called when frame will be obtained from PeerConnection stack. // `peer_name` is name of the peer on which side frame was rendered. virtual void OnFrameRendered(absl::string_view /* peer_name */, - const VideoFrame& frame) {} + const VideoFrame& /* frame */) {} // Will be called if encoder return not WEBRTC_VIDEO_CODEC_OK. // All available codes are listed in // modules/video_coding/include/video_error_codes.h // `peer_name` is name of the peer on which side error acquired. - virtual void OnEncoderError(absl::string_view peer_name, - const VideoFrame& frame, - int32_t error_code) {} + virtual void OnEncoderError(absl::string_view /* peer_name */, + const VideoFrame& /* frame */, + int32_t /* error_code */) {} // Will be called if decoder return not WEBRTC_VIDEO_CODEC_OK. // All available codes are listed in // modules/video_coding/include/video_error_codes.h // `peer_name` is name of the peer on which side error acquired. - virtual void OnDecoderError(absl::string_view peer_name, - uint16_t frame_id, - int32_t error_code, - const DecoderStats& stats) {} + virtual void OnDecoderError(absl::string_view /* peer_name */, + uint16_t /* frame_id */, + int32_t /* error_code */, + const DecoderStats& /* stats */) {} // Will be called every time new stats reports are available for the // Peer Connection identified by `pc_label`. void OnStatsReports( - absl::string_view pc_label, - const rtc::scoped_refptr& report) override {} + absl::string_view /* pc_label */, + const rtc::scoped_refptr& /* report */) override {} // Will be called before test adds new participant in the middle of a call. - virtual void RegisterParticipantInCall(absl::string_view peer_name) {} + virtual void RegisterParticipantInCall(absl::string_view /* peer_name */) {} // Will be called after test removed existing participant in the middle of the // call. - virtual void UnregisterParticipantInCall(absl::string_view peer_name) {} + virtual void UnregisterParticipantInCall(absl::string_view /* peer_name */) {} // Informs analyzer that peer `receiver_peer_name` should not receive any // stream from sender `sender_peer_name`. // This method is a no-op if the sender or the receiver does not exist. - virtual void OnPauseAllStreamsFrom(absl::string_view sender_peer_name, - absl::string_view receiver_peer_name) {} + virtual void OnPauseAllStreamsFrom( + absl::string_view /* sender_peer_name */, + absl::string_view /* receiver_peer_name */) {} // Informs analyzer that peer `receiver_peer_name` is expected to receive all // streams from `sender_peer_name`. // This method is a no-op if the sender or the receiver does not exist. - virtual void OnResumeAllStreamsFrom(absl::string_view sender_peer_name, - absl::string_view receiver_peer_name) {} + virtual void OnResumeAllStreamsFrom( + absl::string_view /* sender_peer_name */, + absl::string_view /* receiver_peer_name */) {} // Tells analyzer that analysis complete and it should calculate final // statistics. @@ -179,7 +181,7 @@ class VideoQualityAnalyzerInterface // Returns the sender peer name of the last stream where this frame was // captured. The sender for this frame id may change when the frame ids wrap // around. Also it will crash, if the specified `frame_id` wasn't captured. - virtual std::string GetSenderPeerName(uint16_t frame_id) const { + virtual std::string GetSenderPeerName(uint16_t /* frame_id */) const { RTC_CHECK(false) << "Not implemented."; } }; diff --git a/api/video_codecs/test/video_encoder_factory_template_tests.cc b/api/video_codecs/test/video_encoder_factory_template_tests.cc index e473297f17..9860104417 100644 --- a/api/video_codecs/test/video_encoder_factory_template_tests.cc +++ b/api/video_codecs/test/video_encoder_factory_template_tests.cc @@ -68,7 +68,7 @@ struct BarEncoderTemplateAdapter { static std::unique_ptr CreateEncoder( const Environment& /* env */, - const SdpVideoFormat& format) { + const SdpVideoFormat& /* format */) { return std::make_unique>(); } diff --git a/api/video_codecs/test/video_encoder_software_fallback_wrapper_unittest.cc b/api/video_codecs/test/video_encoder_software_fallback_wrapper_unittest.cc index 11f234d1c7..c08b3e44ec 100644 --- a/api/video_codecs/test/video_encoder_software_fallback_wrapper_unittest.cc +++ b/api/video_codecs/test/video_encoder_software_fallback_wrapper_unittest.cc @@ -83,8 +83,9 @@ VideoEncoder::EncoderInfo GetEncoderInfoWithHardwareAccelerated( class FakeEncodedImageCallback : public EncodedImageCallback { public: - Result OnEncodedImage(const EncodedImage& encoded_image, - const CodecSpecificInfo* codec_specific_info) override { + Result OnEncodedImage( + const EncodedImage& /* encoded_image */, + const CodecSpecificInfo* /* codec_specific_info */) override { ++callback_count_; return Result(Result::OK, callback_count_); } @@ -109,18 +110,19 @@ class VideoEncoderSoftwareFallbackWrapperTestBase : public ::testing::Test { class CountingFakeEncoder : public VideoEncoder { public: void SetFecControllerOverride( - FecControllerOverride* fec_controller_override) override { + FecControllerOverride* /* fec_controller_override */) override { // Ignored. } - int32_t InitEncode(const VideoCodec* codec_settings, - const VideoEncoder::Settings& settings) override { + int32_t InitEncode(const VideoCodec* /* codec_settings */, + const VideoEncoder::Settings& /* settings */) override { ++init_encode_count_; return init_encode_return_code_; } - int32_t Encode(const VideoFrame& frame, - const std::vector* frame_types) override { + int32_t Encode( + const VideoFrame& frame, + const std::vector* /* frame_types */) override { ++encode_count_; last_video_frame_ = frame; if (encode_complete_callback_ && @@ -141,7 +143,7 @@ class VideoEncoderSoftwareFallbackWrapperTestBase : public ::testing::Test { return WEBRTC_VIDEO_CODEC_OK; } - void SetRates(const RateControlParameters& parameters) override {} + void SetRates(const RateControlParameters& /* parameters */) override {} EncoderInfo GetEncoderInfo() const override { ++supports_native_handle_count_; @@ -986,7 +988,7 @@ TEST_F(PreferTemporalLayersFallbackTest, PrimesEncoderOnSwitch) { FakeEncodedImageCallback callback1; class DummyFecControllerOverride : public FecControllerOverride { public: - void SetFecAllowed(bool fec_allowed) override {} + void SetFecAllowed(bool /* fec_allowed */) override {} }; DummyFecControllerOverride fec_controller_override1; VideoEncoder::RateControlParameters rate_params1; diff --git a/api/video_codecs/video_decoder_factory_template_dav1d_adapter.h b/api/video_codecs/video_decoder_factory_template_dav1d_adapter.h index cf2fc85e45..128d3245c6 100644 --- a/api/video_codecs/video_decoder_factory_template_dav1d_adapter.h +++ b/api/video_codecs/video_decoder_factory_template_dav1d_adapter.h @@ -25,7 +25,7 @@ struct Dav1dDecoderTemplateAdapter { } static std::unique_ptr CreateDecoder( - const SdpVideoFormat& format) { + const SdpVideoFormat& /* format */) { return CreateDav1dDecoder(); } }; diff --git a/api/video_codecs/video_decoder_factory_template_libvpx_vp8_adapter.h b/api/video_codecs/video_decoder_factory_template_libvpx_vp8_adapter.h index 303e320c6e..b5aac982aa 100644 --- a/api/video_codecs/video_decoder_factory_template_libvpx_vp8_adapter.h +++ b/api/video_codecs/video_decoder_factory_template_libvpx_vp8_adapter.h @@ -27,7 +27,7 @@ struct LibvpxVp8DecoderTemplateAdapter { static std::unique_ptr CreateDecoder( const Environment& env, - const SdpVideoFormat& format) { + const SdpVideoFormat& /* format */) { return CreateVp8Decoder(env); } }; diff --git a/api/video_codecs/video_decoder_factory_template_libvpx_vp9_adapter.h b/api/video_codecs/video_decoder_factory_template_libvpx_vp9_adapter.h index 0f329a12a4..7e80988888 100644 --- a/api/video_codecs/video_decoder_factory_template_libvpx_vp9_adapter.h +++ b/api/video_codecs/video_decoder_factory_template_libvpx_vp9_adapter.h @@ -25,7 +25,7 @@ struct LibvpxVp9DecoderTemplateAdapter { } static std::unique_ptr CreateDecoder( - const SdpVideoFormat& format) { + const SdpVideoFormat& /* format */) { return VP9Decoder::Create(); } }; diff --git a/api/video_codecs/video_decoder_factory_template_open_h264_adapter.h b/api/video_codecs/video_decoder_factory_template_open_h264_adapter.h index 7f1d4c8c6b..c17157eed6 100644 --- a/api/video_codecs/video_decoder_factory_template_open_h264_adapter.h +++ b/api/video_codecs/video_decoder_factory_template_open_h264_adapter.h @@ -32,7 +32,7 @@ struct OpenH264DecoderTemplateAdapter { } static std::unique_ptr CreateDecoder( - const SdpVideoFormat& format) { + const SdpVideoFormat& /* format */) { #if defined(WEBRTC_USE_H264) return H264Decoder::Create(); diff --git a/api/video_codecs/video_encoder_factory_template_libaom_av1_adapter.h b/api/video_codecs/video_encoder_factory_template_libaom_av1_adapter.h index 454ba353d9..10cc1cc152 100644 --- a/api/video_codecs/video_encoder_factory_template_libaom_av1_adapter.h +++ b/api/video_codecs/video_encoder_factory_template_libaom_av1_adapter.h @@ -32,7 +32,7 @@ struct LibaomAv1EncoderTemplateAdapter { static std::unique_ptr CreateEncoder( const Environment& env, - const SdpVideoFormat& format) { + const SdpVideoFormat& /* format */) { return CreateLibaomAv1Encoder(env); } diff --git a/api/video_codecs/video_encoder_factory_template_libvpx_vp8_adapter.h b/api/video_codecs/video_encoder_factory_template_libvpx_vp8_adapter.h index fed796fc76..6e8e290a1d 100644 --- a/api/video_codecs/video_encoder_factory_template_libvpx_vp8_adapter.h +++ b/api/video_codecs/video_encoder_factory_template_libvpx_vp8_adapter.h @@ -36,7 +36,7 @@ struct LibvpxVp8EncoderTemplateAdapter { static std::unique_ptr CreateEncoder( const Environment& env, - const SdpVideoFormat& format) { + const SdpVideoFormat& /* format */) { return CreateVp8Encoder(env); } diff --git a/api/video_codecs/video_encoder_factory_template_open_h264_adapter.h b/api/video_codecs/video_encoder_factory_template_open_h264_adapter.h index f72e381e24..837ef6ef98 100644 --- a/api/video_codecs/video_encoder_factory_template_open_h264_adapter.h +++ b/api/video_codecs/video_encoder_factory_template_open_h264_adapter.h @@ -33,8 +33,8 @@ struct OpenH264EncoderTemplateAdapter { } static std::unique_ptr CreateEncoder( - const Environment& env, - const SdpVideoFormat& format) { + [[maybe_unused]] const Environment& env, + [[maybe_unused]] const SdpVideoFormat& format) { #if defined(WEBRTC_USE_H264) return CreateH264Encoder(env, H264EncoderSettings::Parse(format)); #else @@ -42,7 +42,8 @@ struct OpenH264EncoderTemplateAdapter { #endif } - static bool IsScalabilityModeSupported(ScalabilityMode scalability_mode) { + static bool IsScalabilityModeSupported( + [[maybe_unused]] ScalabilityMode scalability_mode) { #if defined(WEBRTC_USE_H264) return H264Encoder::SupportsScalabilityMode(scalability_mode); #else diff --git a/api/video_codecs/vp8_temporal_layers_factory.cc b/api/video_codecs/vp8_temporal_layers_factory.cc index 9457611b1f..9ba589e9c7 100644 --- a/api/video_codecs/vp8_temporal_layers_factory.cc +++ b/api/video_codecs/vp8_temporal_layers_factory.cc @@ -29,7 +29,7 @@ namespace webrtc { std::unique_ptr Vp8TemporalLayersFactory::Create( const VideoCodec& codec, - const VideoEncoder::Settings& settings, + const VideoEncoder::Settings& /* settings */, FecControllerOverride* fec_controller_override) { std::vector> controllers; const int num_streams = SimulcastUtility::NumberOfSimulcastStreams(codec); diff --git a/audio/audio_receive_stream.cc b/audio/audio_receive_stream.cc index 48e1386413..d693a47263 100644 --- a/audio/audio_receive_stream.cc +++ b/audio/audio_receive_stream.cc @@ -95,7 +95,7 @@ AudioReceiveStreamImpl::AudioReceiveStreamImpl( } AudioReceiveStreamImpl::AudioReceiveStreamImpl( - const Environment& env, + const Environment& /* env */, PacketRouter* packet_router, const webrtc::AudioReceiveStreamInterface::Config& config, const rtc::scoped_refptr& audio_state, diff --git a/audio/audio_send_stream_tests.cc b/audio/audio_send_stream_tests.cc index 6e394a7673..e042685e66 100644 --- a/audio/audio_send_stream_tests.cc +++ b/audio/audio_send_stream_tests.cc @@ -64,7 +64,7 @@ TEST_F(AudioSendStreamCallTest, SupportsCName) { void ModifyAudioConfigs(AudioSendStream::Config* send_config, std::vector* - receive_configs) override { + /* receive_configs */) override { send_config->rtp.c_name = kCName; } @@ -93,7 +93,7 @@ TEST_F(AudioSendStreamCallTest, NoExtensionsByDefault) { void ModifyAudioConfigs(AudioSendStream::Config* send_config, std::vector* - receive_configs) override { + /* receive_configs */) override { send_config->rtp.extensions.clear(); } @@ -131,7 +131,7 @@ TEST_F(AudioSendStreamCallTest, SupportsAudioLevel) { void ModifyAudioConfigs(AudioSendStream::Config* send_config, std::vector* - receive_configs) override { + /* receive_configs */) override { send_config->rtp.extensions.clear(); send_config->rtp.extensions.push_back( RtpExtension(RtpExtension::kAudioLevelUri, kAudioLevelExtensionId)); @@ -173,7 +173,7 @@ class TransportWideSequenceNumberObserver : public AudioSendTest { void ModifyAudioConfigs(AudioSendStream::Config* send_config, std::vector* - receive_configs) override { + /* receive_configs */) override { send_config->rtp.extensions.clear(); send_config->rtp.extensions.push_back( RtpExtension(RtpExtension::kTransportSequenceNumberUri, @@ -225,7 +225,7 @@ TEST_F(AudioSendStreamCallTest, SendDtmf) { void OnAudioStreamsCreated(AudioSendStream* send_stream, const std::vector& - receive_streams) override { + /* receive_streams */) override { // Need to start stream here, else DTMF events are dropped. send_stream->Start(); for (int event = kDtmfEventFirst; event <= kDtmfEventLast; ++event) { diff --git a/audio/audio_send_stream_unittest.cc b/audio/audio_send_stream_unittest.cc index 7198a61132..c487d7b87d 100644 --- a/audio/audio_send_stream_unittest.cc +++ b/audio/audio_send_stream_unittest.cc @@ -235,7 +235,8 @@ struct ConfigHelper { void SetupMockForSetupSendCodec(bool expect_set_encoder_call) { if (expect_set_encoder_call) { EXPECT_CALL(*channel_send_, SetEncoder) - .WillOnce([this](int payload_type, const SdpAudioFormat& format, + .WillOnce([this](int /* payload_type */, + const SdpAudioFormat& /* format */, std::unique_ptr encoder) { this->audio_encoder_ = std::move(encoder); return true; @@ -581,8 +582,8 @@ TEST(AudioSendStreamTest, SendCodecCanApplyVad) { helper.config().send_codec_spec->cng_payload_type = 105; std::unique_ptr stolen_encoder; EXPECT_CALL(*helper.channel_send(), SetEncoder) - .WillOnce([&stolen_encoder](int payload_type, - const SdpAudioFormat& format, + .WillOnce([&stolen_encoder](int /* payload_type */, + const SdpAudioFormat& /* format */, std::unique_ptr encoder) { stolen_encoder = std::move(encoder); return true; diff --git a/audio/audio_state_unittest.cc b/audio/audio_state_unittest.cc index 070e220979..954e6c19c3 100644 --- a/audio/audio_state_unittest.cc +++ b/audio/audio_state_unittest.cc @@ -52,8 +52,8 @@ struct FakeAsyncAudioProcessingHelper { FakeTaskQueueFactory() = default; ~FakeTaskQueueFactory() override = default; std::unique_ptr CreateTaskQueue( - absl::string_view name, - Priority priority) const override { + absl::string_view /* name */, + Priority /* priority */) const override { return std::unique_ptr( new FakeTaskQueue()); } diff --git a/audio/channel_receive_unittest.cc b/audio/channel_receive_unittest.cc index ef9647d785..1c04fc98c9 100644 --- a/audio/channel_receive_unittest.cc +++ b/audio/channel_receive_unittest.cc @@ -128,7 +128,7 @@ class ChannelReceiveTest : public Test { return packet; } - void HandleGeneratedRtcp(ChannelReceiveInterface& channel, + void HandleGeneratedRtcp(ChannelReceiveInterface& /* channel */, rtc::ArrayView packet) { if (packet[1] == rtcp::ReceiverReport::kPacketType) { // Ignore RR, it requires no response diff --git a/audio/channel_send_frame_transformer_delegate_unittest.cc b/audio/channel_send_frame_transformer_delegate_unittest.cc index a4ee9ff208..aa4eb783a8 100644 --- a/audio/channel_send_frame_transformer_delegate_unittest.cc +++ b/audio/channel_send_frame_transformer_delegate_unittest.cc @@ -188,10 +188,11 @@ TEST(ChannelSendFrameTransformerDelegateTest, SendFrame(_, 0, 0, ElementsAreArray(mock_data), _, ElementsAreArray(csrcs), Optional(audio_level_dbov))); ON_CALL(*mock_frame_transformer, Transform) - .WillByDefault([&](std::unique_ptr frame) { - callback->OnTransformedFrame(CreateMockReceiverFrame( - csrcs, std::optional(audio_level_dbov))); - }); + .WillByDefault( + [&](std::unique_ptr /* frame */) { + callback->OnTransformedFrame(CreateMockReceiverFrame( + csrcs, std::optional(audio_level_dbov))); + }); delegate->Transform(AudioFrameType::kEmptyFrame, 0, 0, mock_data, sizeof(mock_data), 0, /*ssrc=*/0, /*mimeType=*/"audio/opus", diff --git a/audio/channel_send_unittest.cc b/audio/channel_send_unittest.cc index 31cdaa0c0d..25b48312b1 100644 --- a/audio/channel_send_unittest.cc +++ b/audio/channel_send_unittest.cc @@ -153,7 +153,7 @@ TEST_F(ChannelSendTest, IncreaseRtpTimestampByPauseDuration) { uint32_t timestamp; int sent_packets = 0; auto send_rtp = [&](rtc::ArrayView data, - const PacketOptions& options) { + const PacketOptions& /* options */) { ++sent_packets; RtpPacketReceived packet; packet.Parse(data); diff --git a/audio/test/audio_end_to_end_test.cc b/audio/test/audio_end_to_end_test.cc index 769d7d32d5..746ae3fea7 100644 --- a/audio/test/audio_end_to_end_test.cc +++ b/audio/test/audio_end_to_end_test.cc @@ -55,13 +55,13 @@ AudioEndToEndTest::CreateRenderer() { void AudioEndToEndTest::OnFakeAudioDevicesCreated( AudioDeviceModule* send_audio_device, - AudioDeviceModule* recv_audio_device) { + AudioDeviceModule* /* recv_audio_device */) { send_audio_device_ = send_audio_device; } void AudioEndToEndTest::ModifyAudioConfigs( AudioSendStream::Config* send_config, - std::vector* receive_configs) { + std::vector* /* receive_configs */) { // Large bitrate by default. const webrtc::SdpAudioFormat kDefaultFormat("opus", 48000, 2, {{"stereo", "1"}}); diff --git a/audio/voip/test/mock_task_queue.h b/audio/voip/test/mock_task_queue.h index 547b0d3f75..6a769bfefb 100644 --- a/audio/voip/test/mock_task_queue.h +++ b/audio/voip/test/mock_task_queue.h @@ -39,8 +39,8 @@ class MockTaskQueueFactory : public TaskQueueFactory { : task_queue_(task_queue) {} std::unique_ptr CreateTaskQueue( - absl::string_view name, - Priority priority) const override { + absl::string_view /* name */, + Priority /* priority */) const override { // Default MockTaskQueue::Delete is no-op, therefore it's safe to pass the // raw pointer. return std::unique_ptr(task_queue_); diff --git a/call/adaptation/resource_adaptation_processor.cc b/call/adaptation/resource_adaptation_processor.cc index f4d1bf3538..4d46ddec52 100644 --- a/call/adaptation/resource_adaptation_processor.cc +++ b/call/adaptation/resource_adaptation_processor.cc @@ -357,7 +357,7 @@ void ResourceAdaptationProcessor::UpdateResourceLimitations( } void ResourceAdaptationProcessor::OnVideoSourceRestrictionsUpdated( - VideoSourceRestrictions restrictions, + VideoSourceRestrictions /* restrictions */, const VideoAdaptationCounters& adaptation_counters, rtc::scoped_refptr reason, const VideoSourceRestrictions& unfiltered_restrictions) { diff --git a/call/adaptation/resource_adaptation_processor_unittest.cc b/call/adaptation/resource_adaptation_processor_unittest.cc index ccccd3fe04..acd9053f67 100644 --- a/call/adaptation/resource_adaptation_processor_unittest.cc +++ b/call/adaptation/resource_adaptation_processor_unittest.cc @@ -65,7 +65,7 @@ class VideoSourceRestrictionsListenerForTesting VideoSourceRestrictions restrictions, const VideoAdaptationCounters& adaptation_counters, rtc::scoped_refptr reason, - const VideoSourceRestrictions& unfiltered_restrictions) override { + const VideoSourceRestrictions& /* unfiltered_restrictions */) override { RTC_DCHECK_RUN_ON(&sequence_checker_); ++restrictions_updated_count_; restrictions_ = restrictions; diff --git a/call/adaptation/resource_unittest.cc b/call/adaptation/resource_unittest.cc index a2291dfdce..e806756a89 100644 --- a/call/adaptation/resource_unittest.cc +++ b/call/adaptation/resource_unittest.cc @@ -36,7 +36,7 @@ TEST_F(ResourceTest, RegisteringListenerReceivesCallbacks) { fake_resource_->SetResourceListener(&resource_listener); EXPECT_CALL(resource_listener, OnResourceUsageStateMeasured(_, _)) .Times(1) - .WillOnce([](rtc::scoped_refptr resource, + .WillOnce([](rtc::scoped_refptr /* resource */, ResourceUsageState usage_state) { EXPECT_EQ(ResourceUsageState::kOveruse, usage_state); }); diff --git a/call/adaptation/test/fake_adaptation_constraint.cc b/call/adaptation/test/fake_adaptation_constraint.cc index dbb31f0d3b..8fc5f671b2 100644 --- a/call/adaptation/test/fake_adaptation_constraint.cc +++ b/call/adaptation/test/fake_adaptation_constraint.cc @@ -31,9 +31,9 @@ std::string FakeAdaptationConstraint::Name() const { } bool FakeAdaptationConstraint::IsAdaptationUpAllowed( - const VideoStreamInputState& input_state, - const VideoSourceRestrictions& restrictions_before, - const VideoSourceRestrictions& restrictions_after) const { + const VideoStreamInputState& /* input_state */, + const VideoSourceRestrictions& /* restrictions_before */, + const VideoSourceRestrictions& /* restrictions_after */) const { return is_adaptation_up_allowed_; } diff --git a/call/adaptation/video_stream_adapter.cc b/call/adaptation/video_stream_adapter.cc index eb949c9628..0275b56379 100644 --- a/call/adaptation/video_stream_adapter.cc +++ b/call/adaptation/video_stream_adapter.cc @@ -686,7 +686,7 @@ Adaptation VideoStreamAdapter::GetAdaptationTo( } void VideoStreamAdapter::BroadcastVideoRestrictionsUpdate( - const VideoStreamInputState& input_state, + const VideoStreamInputState& /* input_state */, const rtc::scoped_refptr& resource) { RTC_DCHECK_RUN_ON(&sequence_checker_); VideoSourceRestrictions filtered = FilterRestrictionsByDegradationPreference( diff --git a/call/adaptation/video_stream_adapter_unittest.cc b/call/adaptation/video_stream_adapter_unittest.cc index 162adf9bf7..e5521cd3fd 100644 --- a/call/adaptation/video_stream_adapter_unittest.cc +++ b/call/adaptation/video_stream_adapter_unittest.cc @@ -114,9 +114,9 @@ class FakeVideoStream { class FakeVideoStreamAdapterListner : public VideoSourceRestrictionsListener { public: void OnVideoSourceRestrictionsUpdated( - VideoSourceRestrictions restrictions, - const VideoAdaptationCounters& adaptation_counters, - rtc::scoped_refptr reason, + VideoSourceRestrictions /* restrictions */, + const VideoAdaptationCounters& /* adaptation_counters */, + rtc::scoped_refptr /* reason */, const VideoSourceRestrictions& unfiltered_restrictions) override { calls_++; last_restrictions_ = unfiltered_restrictions; diff --git a/call/bitrate_allocator.cc b/call/bitrate_allocator.cc index cd4260f833..1818b6746d 100644 --- a/call/bitrate_allocator.cc +++ b/call/bitrate_allocator.cc @@ -305,7 +305,7 @@ std::map NormalRateAllocation( std::map MaxRateAllocation( const std::vector& allocatable_tracks, uint32_t bitrate, - uint32_t sum_max_bitrates) { + uint32_t /* sum_max_bitrates */) { std::map allocation; for (const auto& observer_config : allocatable_tracks) { diff --git a/call/bitrate_allocator_unittest.cc b/call/bitrate_allocator_unittest.cc index b8f0abf524..de8c61f23b 100644 --- a/call/bitrate_allocator_unittest.cc +++ b/call/bitrate_allocator_unittest.cc @@ -332,7 +332,7 @@ class BitrateAllocatorTestNoEnforceMin : public ::testing::Test { uint32_t max_bitrate_bps, uint32_t pad_up_bitrate_bps, bool enforce_min_bitrate, - absl::string_view track_id, + absl::string_view /* track_id */, double bitrate_priority) { allocator_->AddObserver( observer, {min_bitrate_bps, max_bitrate_bps, pad_up_bitrate_bps, 0,