diff --git a/modules/pacing/BUILD.gn b/modules/pacing/BUILD.gn index 7878676e74..21d529ff04 100644 --- a/modules/pacing/BUILD.gn +++ b/modules/pacing/BUILD.gn @@ -30,9 +30,11 @@ rtc_library("pacing") { deps = [ ":interval_budget", + "../../api:array_view", "../../api:field_trials_view", "../../api:field_trials_view", "../../api:function_view", + "../../api:rtp_headers", "../../api:rtp_packet_sender", "../../api:sequence_checker", "../../api/rtc_event_log", @@ -51,6 +53,7 @@ rtc_library("pacing") { "../../rtc_base:logging", "../../rtc_base:macromagic", "../../rtc_base:rtc_numerics", + "../../rtc_base:safe_conversions", "../../rtc_base:timeutils", "../../rtc_base/experiments:field_trial_parser", "../../rtc_base/synchronization:mutex", @@ -94,6 +97,9 @@ if (rtc_include_tests) { deps = [ ":interval_budget", ":pacing", + "../../api:array_view", + "../../api:rtp_headers", + "../../api:sequence_checker", "../../api/task_queue:task_queue", "../../api/transport:field_trial_based_config", "../../api/transport:network_control", diff --git a/modules/pacing/bitrate_prober.cc b/modules/pacing/bitrate_prober.cc index 5b6142a78a..dc9f4beab7 100644 --- a/modules/pacing/bitrate_prober.cc +++ b/modules/pacing/bitrate_prober.cc @@ -11,11 +11,17 @@ #include "modules/pacing/bitrate_prober.h" #include +#include +#include #include "api/field_trials_view.h" +#include "api/transport/network_types.h" +#include "api/units/data_rate.h" #include "api/units/data_size.h" #include "api/units/time_delta.h" +#include "api/units/timestamp.h" #include "rtc_base/checks.h" +#include "rtc_base/experiments/field_trial_parser.h" #include "rtc_base/logging.h" namespace webrtc { diff --git a/modules/pacing/bitrate_prober.h b/modules/pacing/bitrate_prober.h index 7ceb129918..86da9c1794 100644 --- a/modules/pacing/bitrate_prober.h +++ b/modules/pacing/bitrate_prober.h @@ -12,12 +12,13 @@ #define MODULES_PACING_BITRATE_PROBER_H_ #include -#include +#include #include #include "api/field_trials_view.h" #include "api/transport/network_types.h" +#include "api/units/data_size.h" #include "api/units/time_delta.h" #include "api/units/timestamp.h" #include "rtc_base/experiments/field_trial_parser.h" diff --git a/modules/pacing/bitrate_prober_unittest.cc b/modules/pacing/bitrate_prober_unittest.cc index 2954398e25..826e895aa4 100644 --- a/modules/pacing/bitrate_prober_unittest.cc +++ b/modules/pacing/bitrate_prober_unittest.cc @@ -15,6 +15,7 @@ #include "api/transport/field_trial_based_config.h" #include "api/transport/network_types.h" #include "api/units/data_rate.h" +#include "api/units/data_size.h" #include "api/units/time_delta.h" #include "api/units/timestamp.h" #include "test/explicit_key_value_config.h" diff --git a/modules/pacing/interval_budget.cc b/modules/pacing/interval_budget.cc index 321ca46be4..2057c2d3c3 100644 --- a/modules/pacing/interval_budget.cc +++ b/modules/pacing/interval_budget.cc @@ -11,6 +11,8 @@ #include "modules/pacing/interval_budget.h" #include +#include +#include #include "rtc_base/numerics/safe_conversions.h" diff --git a/modules/pacing/interval_budget_unittest.cc b/modules/pacing/interval_budget_unittest.cc index e182d35510..8be0f6186d 100644 --- a/modules/pacing/interval_budget_unittest.cc +++ b/modules/pacing/interval_budget_unittest.cc @@ -10,6 +10,8 @@ #include "modules/pacing/interval_budget.h" +#include + #include "test/gtest.h" namespace webrtc { diff --git a/modules/pacing/pacing_controller.cc b/modules/pacing/pacing_controller.cc index 5999fa50ff..011b1c8462 100644 --- a/modules/pacing/pacing_controller.cc +++ b/modules/pacing/pacing_controller.cc @@ -11,12 +11,21 @@ #include "modules/pacing/pacing_controller.h" #include +#include +#include +#include #include +#include #include #include #include "absl/cleanup/cleanup.h" #include "absl/strings/match.h" +#include "absl/strings/string_view.h" +#include "api/array_view.h" +#include "api/field_trials_view.h" +#include "api/transport/network_types.h" +#include "api/units/data_rate.h" #include "api/units/data_size.h" #include "api/units/time_delta.h" #include "api/units/timestamp.h" @@ -24,6 +33,7 @@ #include "modules/rtp_rtcp/include/rtp_rtcp_defines.h" #include "rtc_base/checks.h" #include "rtc_base/logging.h" +#include "rtc_base/numerics/safe_conversions.h" #include "system_wrappers/include/clock.h" namespace webrtc { diff --git a/modules/pacing/pacing_controller.h b/modules/pacing/pacing_controller.h index db70ec986a..880af2917d 100644 --- a/modules/pacing/pacing_controller.h +++ b/modules/pacing/pacing_controller.h @@ -15,26 +15,23 @@ #include #include -#include #include #include #include +#include "api/array_view.h" #include "api/field_trials_view.h" -#include "api/function_view.h" #include "api/rtp_packet_sender.h" -#include "api/transport/field_trial_based_config.h" #include "api/transport/network_types.h" +#include "api/units/data_rate.h" #include "api/units/data_size.h" #include "api/units/time_delta.h" +#include "api/units/timestamp.h" #include "modules/pacing/bitrate_prober.h" -#include "modules/pacing/interval_budget.h" #include "modules/pacing/prioritized_packet_queue.h" -#include "modules/pacing/rtp_packet_pacer.h" #include "modules/rtp_rtcp/include/rtp_rtcp_defines.h" #include "modules/rtp_rtcp/source/rtp_packet_to_send.h" -#include "rtc_base/experiments/field_trial_parser.h" -#include "rtc_base/thread_annotations.h" +#include "system_wrappers/include/clock.h" namespace webrtc { diff --git a/modules/pacing/pacing_controller_unittest.cc b/modules/pacing/pacing_controller_unittest.cc index 01430ff6be..4618bd3c26 100644 --- a/modules/pacing/pacing_controller_unittest.cc +++ b/modules/pacing/pacing_controller_unittest.cc @@ -11,16 +11,24 @@ #include "modules/pacing/pacing_controller.h" #include +#include #include +#include +#include #include +#include #include #include +#include "api/array_view.h" #include "api/transport/network_types.h" #include "api/units/data_rate.h" #include "api/units/data_size.h" #include "api/units/time_delta.h" #include "api/units/timestamp.h" +#include "modules/pacing/bitrate_prober.h" +#include "modules/rtp_rtcp/include/rtp_rtcp_defines.h" +#include "modules/rtp_rtcp/source/rtp_packet_to_send.h" #include "system_wrappers/include/clock.h" #include "test/explicit_key_value_config.h" #include "test/gmock.h" diff --git a/modules/pacing/packet_router.cc b/modules/pacing/packet_router.cc index 8f4d492992..f85a9af9bc 100644 --- a/modules/pacing/packet_router.cc +++ b/modules/pacing/packet_router.cc @@ -12,15 +12,20 @@ #include #include -#include #include #include #include +#include #include "absl/functional/any_invocable.h" +#include "api/array_view.h" +#include "api/rtp_headers.h" +#include "api/sequence_checker.h" #include "api/transport/network_types.h" +#include "api/units/data_size.h" #include "modules/rtp_rtcp/include/rtp_rtcp_defines.h" #include "modules/rtp_rtcp/source/rtcp_packet.h" +#include "modules/rtp_rtcp/source/rtp_header_extensions.h" #include "modules/rtp_rtcp/source/rtp_rtcp_interface.h" #include "rtc_base/checks.h" #include "rtc_base/logging.h" diff --git a/modules/pacing/packet_router.h b/modules/pacing/packet_router.h index 1422645319..be0617dfdd 100644 --- a/modules/pacing/packet_router.h +++ b/modules/pacing/packet_router.h @@ -17,14 +17,16 @@ #include #include #include +#include #include #include -#include #include #include "absl/functional/any_invocable.h" +#include "api/array_view.h" #include "api/sequence_checker.h" #include "api/transport/network_types.h" +#include "api/units/data_size.h" #include "modules/pacing/pacing_controller.h" #include "modules/rtp_rtcp/include/rtp_rtcp_defines.h" #include "modules/rtp_rtcp/source/rtcp_packet.h" diff --git a/modules/pacing/packet_router_unittest.cc b/modules/pacing/packet_router_unittest.cc index 20e9622e65..f9a55c7648 100644 --- a/modules/pacing/packet_router_unittest.cc +++ b/modules/pacing/packet_router_unittest.cc @@ -13,12 +13,20 @@ #include #include #include +#include #include +#include +#include "api/rtp_headers.h" +#include "api/transport/network_types.h" +#include "api/units/data_size.h" #include "api/units/time_delta.h" #include "modules/rtp_rtcp/include/rtp_header_extension_map.h" +#include "modules/rtp_rtcp/include/rtp_rtcp_defines.h" #include "modules/rtp_rtcp/mocks/mock_rtp_rtcp.h" +#include "modules/rtp_rtcp/source/rtcp_packet.h" #include "modules/rtp_rtcp/source/rtcp_packet/transport_feedback.h" +#include "modules/rtp_rtcp/source/rtp_header_extensions.h" #include "modules/rtp_rtcp/source/rtp_packet_to_send.h" #include "rtc_base/checks.h" #include "rtc_base/fake_clock.h" @@ -35,19 +43,13 @@ namespace webrtc { namespace { using ::testing::_; -using ::testing::AnyNumber; -using ::testing::AtLeast; using ::testing::ElementsAreArray; -using ::testing::Field; -using ::testing::Gt; using ::testing::InSequence; -using ::testing::Le; using ::testing::MockFunction; using ::testing::NiceMock; using ::testing::Pointee; using ::testing::Property; using ::testing::Return; -using ::testing::SaveArg; constexpr int kProbeMinProbes = 5; constexpr int kProbeMinBytes = 1000; diff --git a/modules/pacing/prioritized_packet_queue.cc b/modules/pacing/prioritized_packet_queue.cc index fa2ad7de10..1fd1066d20 100644 --- a/modules/pacing/prioritized_packet_queue.cc +++ b/modules/pacing/prioritized_packet_queue.cc @@ -12,10 +12,15 @@ #include #include +#include +#include +#include +#include #include #include #include "absl/container/inlined_vector.h" +#include "api/units/data_size.h" #include "api/units/time_delta.h" #include "api/units/timestamp.h" #include "modules/rtp_rtcp/include/rtp_rtcp_defines.h" diff --git a/modules/pacing/prioritized_packet_queue.h b/modules/pacing/prioritized_packet_queue.h index 179ef104fe..bb6465d755 100644 --- a/modules/pacing/prioritized_packet_queue.h +++ b/modules/pacing/prioritized_packet_queue.h @@ -14,6 +14,7 @@ #include #include +#include #include #include #include @@ -23,6 +24,7 @@ #include "api/units/data_size.h" #include "api/units/time_delta.h" #include "api/units/timestamp.h" +#include "modules/rtp_rtcp/include/rtp_rtcp_defines.h" #include "modules/rtp_rtcp/source/rtp_packet_to_send.h" namespace webrtc { diff --git a/modules/pacing/prioritized_packet_queue_unittest.cc b/modules/pacing/prioritized_packet_queue_unittest.cc index 76c31036b3..6370fac79c 100644 --- a/modules/pacing/prioritized_packet_queue_unittest.cc +++ b/modules/pacing/prioritized_packet_queue_unittest.cc @@ -10,14 +10,17 @@ #include "modules/pacing/prioritized_packet_queue.h" +#include +#include #include #include +#include "api/units/data_size.h" #include "api/units/time_delta.h" +#include "api/units/timestamp.h" #include "modules/rtp_rtcp/include/rtp_rtcp_defines.h" #include "modules/rtp_rtcp/source/rtp_packet_to_send.h" #include "rtc_base/checks.h" -#include "test/gmock.h" #include "test/gtest.h" namespace webrtc { diff --git a/modules/pacing/rtp_packet_pacer.h b/modules/pacing/rtp_packet_pacer.h index f388c07ad5..d1951639a5 100644 --- a/modules/pacing/rtp_packet_pacer.h +++ b/modules/pacing/rtp_packet_pacer.h @@ -11,7 +11,6 @@ #ifndef MODULES_PACING_RTP_PACKET_PACER_H_ #define MODULES_PACING_RTP_PACKET_PACER_H_ -#include #include #include diff --git a/modules/pacing/task_queue_paced_sender.cc b/modules/pacing/task_queue_paced_sender.cc index ca897705a5..ef94a98fb9 100644 --- a/modules/pacing/task_queue_paced_sender.cc +++ b/modules/pacing/task_queue_paced_sender.cc @@ -11,12 +11,27 @@ #include "modules/pacing/task_queue_paced_sender.h" #include +#include +#include +#include +#include #include +#include #include "absl/cleanup/cleanup.h" +#include "api/field_trials_view.h" +#include "api/sequence_checker.h" #include "api/task_queue/pending_task_safety_flag.h" +#include "api/task_queue/task_queue_base.h" #include "api/transport/network_types.h" +#include "api/units/data_rate.h" +#include "api/units/data_size.h" +#include "api/units/time_delta.h" +#include "api/units/timestamp.h" +#include "modules/pacing/pacing_controller.h" +#include "modules/rtp_rtcp/source/rtp_packet_to_send.h" #include "rtc_base/checks.h" +#include "rtc_base/numerics/exp_filter.h" #include "rtc_base/trace_event.h" namespace webrtc { diff --git a/modules/pacing/task_queue_paced_sender.h b/modules/pacing/task_queue_paced_sender.h index be2bc84ab7..bc46a75740 100644 --- a/modules/pacing/task_queue_paced_sender.h +++ b/modules/pacing/task_queue_paced_sender.h @@ -19,15 +19,18 @@ #include #include "api/field_trials_view.h" +#include "api/rtp_packet_sender.h" #include "api/sequence_checker.h" #include "api/task_queue/pending_task_safety_flag.h" +#include "api/task_queue/task_queue_base.h" +#include "api/transport/network_types.h" +#include "api/units/data_rate.h" #include "api/units/data_size.h" #include "api/units/time_delta.h" #include "api/units/timestamp.h" #include "modules/pacing/pacing_controller.h" #include "modules/pacing/rtp_packet_pacer.h" #include "modules/rtp_rtcp/source/rtp_packet_to_send.h" -#include "rtc_base/experiments/field_trial_parser.h" #include "rtc_base/numerics/exp_filter.h" #include "rtc_base/thread_annotations.h" diff --git a/modules/pacing/task_queue_paced_sender_unittest.cc b/modules/pacing/task_queue_paced_sender_unittest.cc index fda66150a0..061cf1dd26 100644 --- a/modules/pacing/task_queue_paced_sender_unittest.cc +++ b/modules/pacing/task_queue_paced_sender_unittest.cc @@ -11,20 +11,20 @@ #include "modules/pacing/task_queue_paced_sender.h" #include -#include -#include -#include +#include +#include #include -#include #include #include +#include "api/sequence_checker.h" #include "api/task_queue/task_queue_base.h" #include "api/task_queue/task_queue_factory.h" #include "api/transport/network_types.h" #include "api/units/data_rate.h" #include "api/units/data_size.h" #include "api/units/time_delta.h" +#include "api/units/timestamp.h" #include "modules/pacing/pacing_controller.h" #include "modules/pacing/packet_router.h" #include "modules/rtp_rtcp/include/rtp_rtcp_defines.h" @@ -36,10 +36,7 @@ using ::testing::_; using ::testing::AtLeast; using ::testing::AtMost; -using ::testing::Lt; using ::testing::NiceMock; -using ::testing::Return; -using ::testing::SaveArg; namespace webrtc { namespace {