From c908f1c19aea0b3614aa8733de45fd9ee37d5b38 Mon Sep 17 00:00:00 2001 From: Harald Alvestrand Date: Thu, 17 Dec 2020 19:28:29 +0000 Subject: [PATCH] Declare the Clone operator of SessionDescriptionInterface as const. Bug: webrtc:12215 Change-Id: I8e44e2b9365893ecf481e69060771c2c208bbcdf Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/198125 Reviewed-by: Markus Handell Commit-Queue: Harald Alvestrand Cr-Commit-Position: refs/heads/master@{#32858} --- api/jsep.h | 2 +- api/jsep_session_description.h | 2 +- pc/jsep_session_description.cc | 3 ++- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/api/jsep.h b/api/jsep.h index 7ef4c5364f..dcf821369e 100644 --- a/api/jsep.h +++ b/api/jsep.h @@ -139,7 +139,7 @@ class RTC_EXPORT SessionDescriptionInterface { // Create a new SessionDescriptionInterface object // with the same values as the old object. // TODO(bugs.webrtc.org:12215): Remove default implementation - virtual std::unique_ptr Clone() { + virtual std::unique_ptr Clone() const { return nullptr; } diff --git a/api/jsep_session_description.h b/api/jsep_session_description.h index 0ba3807026..e13d85e71c 100644 --- a/api/jsep_session_description.h +++ b/api/jsep_session_description.h @@ -49,7 +49,7 @@ class JsepSessionDescription : public SessionDescriptionInterface { const std::string& session_id, const std::string& session_version); - virtual std::unique_ptr Clone(); + virtual std::unique_ptr Clone() const; virtual cricket::SessionDescription* description() { return description_.get(); diff --git a/pc/jsep_session_description.cc b/pc/jsep_session_description.cc index 2334e92b9a..e0b23110a1 100644 --- a/pc/jsep_session_description.cc +++ b/pc/jsep_session_description.cc @@ -215,7 +215,8 @@ bool JsepSessionDescription::Initialize( return true; } -std::unique_ptr JsepSessionDescription::Clone() { +std::unique_ptr JsepSessionDescription::Clone() + const { auto new_description = std::make_unique(type_); new_description->Initialize(description_->Clone(), session_id_, session_version_);