From cab60a0842e180b4aafe4cb280c473d58594f6dd Mon Sep 17 00:00:00 2001 From: Philipp Hancke Date: Thu, 5 Dec 2024 13:36:53 -0800 Subject: [PATCH] Provide default implementation of IceTransportInternal::config() to be deleted when downstream consumers are upgraded BUG=webrtc:367395350 Change-Id: I35f1fefdc6535ad443b86176ea600455c2361834 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/370284 Commit-Queue: Philipp Hancke Reviewed-by: Harald Alvestrand Cr-Commit-Position: refs/heads/main@{#43502} --- p2p/base/ice_transport_internal.h | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/p2p/base/ice_transport_internal.h b/p2p/base/ice_transport_internal.h index 707c28a255..a0cdbbc78f 100644 --- a/p2p/base/ice_transport_internal.h +++ b/p2p/base/ice_transport_internal.h @@ -282,7 +282,10 @@ class RTC_EXPORT IceTransportInternal : public rtc::PacketTransportInternal { virtual void SetRemoteIceMode(IceMode mode) = 0; virtual void SetIceConfig(const IceConfig& config) = 0; - virtual const IceConfig& config() const = 0; + // Default implementation in order to allow downstream usage deletion. + // TODO: bugs.webrtc.org/367395350 - Make virutal when all downstream + // overrides are gone. + virtual const IceConfig& config() const { RTC_CHECK_NOTREACHED(); } // Start gathering candidates if not already started, or if an ICE restart // occurred.