diff --git a/api/audio/audio_processing.h b/api/audio/audio_processing.h index d5cdb44471..19eab84507 100644 --- a/api/audio/audio_processing.h +++ b/api/audio/audio_processing.h @@ -221,6 +221,7 @@ class RTC_EXPORT AudioProcessing : public RefCountInterface { bool analyze_linear_aec_output_when_available = false; } noise_suppression; + // TODO(bugs.webrtc.org/357281131): Deprecated. Stop using and remove. // Enables transient suppression. struct TransientSuppression { bool enabled = false; diff --git a/modules/audio_processing/audio_processing_impl.cc b/modules/audio_processing/audio_processing_impl.cc index f093e5fd07..9a831d9435 100644 --- a/modules/audio_processing/audio_processing_impl.cc +++ b/modules/audio_processing/audio_processing_impl.cc @@ -471,10 +471,6 @@ AudioProcessingImpl::AudioProcessingImpl( RTC_LOG(LS_INFO) << "Denormal disabler unsupported"; } - // TODO(bugs.webrtc.org/7494): Remove transient suppression from the config. - // Disable for clarity; enabling transient suppression has no effect. - config_.transient_suppression.enabled = false; - RTC_LOG(LS_INFO) << "AudioProcessing: " << config_.ToString(); // Mark Echo Controller enabled if a factory is injected. @@ -710,10 +706,6 @@ void AudioProcessingImpl::ApplyConfig(const AudioProcessing::Config& config) { config_ = config; - // TODO(bugs.webrtc.org/7494): Remove transient suppression from the config. - // Disable for clarity; enabling transient suppression has no effect. - config_.transient_suppression.enabled = false; - if (aec_config_changed) { InitializeEchoController(); } @@ -2186,9 +2178,6 @@ void AudioProcessingImpl::WriteAecDumpConfigMessage(bool forced) { apm_config.ns_enabled = config_.noise_suppression.enabled; apm_config.ns_level = static_cast(config_.noise_suppression.level); - // TODO(bugs.webrtc.org/7494): Remove transient suppression from the config. - // Disable for clarity; enabling transient suppression has no effect. - apm_config.transient_suppression_enabled = false; apm_config.experiments_description = experiments_description; apm_config.pre_amplifier_enabled = config_.pre_amplifier.enabled; apm_config.pre_amplifier_fixed_gain_factor = diff --git a/modules/audio_processing/audio_processing_impl_unittest.cc b/modules/audio_processing/audio_processing_impl_unittest.cc index 2cfddaf44f..82e65501fc 100644 --- a/modules/audio_processing/audio_processing_impl_unittest.cc +++ b/modules/audio_processing/audio_processing_impl_unittest.cc @@ -959,36 +959,4 @@ INSTANTIATE_TEST_SUITE_P( .input_volume_controller = {.enabled = true}, .adaptive_digital = {.enabled = true}}})); -TEST(AudioProcessingImplTest, CanDisableTransientSuppressor) { - constexpr AudioProcessing::Config kOriginal = { - .transient_suppression = {.enabled = false}}; - - // Test config application via `AudioProcessing` ctor. - auto adjusted = - AudioProcessingBuilder().SetConfig(kOriginal).Create()->GetConfig(); - EXPECT_FALSE(adjusted.transient_suppression.enabled); - - // Test config application via `AudioProcessing::ApplyConfig()`. - auto apm = AudioProcessingBuilder().Create(); - apm->ApplyConfig(kOriginal); - adjusted = apm->GetConfig(); - EXPECT_FALSE(apm->GetConfig().transient_suppression.enabled); -} - -TEST(AudioProcessingImplTest, CannotEnableTs) { - constexpr AudioProcessing::Config kOriginal = { - .transient_suppression = {.enabled = true}}; - - // Test config application via `AudioProcessing` ctor. - auto adjusted = - AudioProcessingBuilder().SetConfig(kOriginal).Create()->GetConfig(); - EXPECT_FALSE(adjusted.transient_suppression.enabled); - - // Test config application via `AudioProcessing::ApplyConfig()`. - auto apm = AudioProcessingBuilder().Create(); - apm->ApplyConfig(kOriginal); - adjusted = apm->GetConfig(); - EXPECT_FALSE(adjusted.transient_suppression.enabled); -} - } // namespace webrtc