From ce0302821672796bd96253acc5c83a05174449db Mon Sep 17 00:00:00 2001 From: Mirko Bonadei Date: Thu, 1 Sep 2022 18:19:42 +0200 Subject: [PATCH] Add -Wctad-maybe-unsupported. This will allow to catch issues (like the one that caused the revert [1]) at CQ time. [1] - https://webrtc-review.googlesource.com/c/src/+/273486 Bug: None Change-Id: Ib12c15dcdc3e2a358d40c1a2ffabfbf42274e978 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/273660 Auto-Submit: Mirko Bonadei Reviewed-by: Tomas Gunnarsson Commit-Queue: Mirko Bonadei Cr-Commit-Position: refs/heads/main@{#37982} --- BUILD.gn | 10 ++++++++-- .../linux/wayland/shared_screencast_stream.cc | 3 ++- 2 files changed, 10 insertions(+), 3 deletions(-) diff --git a/BUILD.gn b/BUILD.gn index 31ee99b9d0..92941f0250 100644 --- a/BUILD.gn +++ b/BUILD.gn @@ -318,9 +318,15 @@ config("common_config") { defines += [ "WEBRTC_EXCLUDE_AUDIO_PROCESSING_MODULE" ] } - # TODO(webrtc:13219): Fix -Wshadow instances and enable. if (is_clang) { - cflags += [ "-Wno-shadow" ] + cflags += [ + # TODO(webrtc:13219): Fix -Wshadow instances and enable. + "-Wno-shadow", + + # See https://reviews.llvm.org/D56731 for details about this + # warning. + "-Wctad-maybe-unsupported", + ] } if (build_with_chromium) { diff --git a/modules/desktop_capture/linux/wayland/shared_screencast_stream.cc b/modules/desktop_capture/linux/wayland/shared_screencast_stream.cc index 99cfa6f456..0ca75d00fc 100644 --- a/modules/desktop_capture/linux/wayland/shared_screencast_stream.cc +++ b/modules/desktop_capture/linux/wayland/shared_screencast_stream.cc @@ -850,7 +850,8 @@ SharedScreenCastStream::~SharedScreenCastStream() {} rtc::scoped_refptr SharedScreenCastStream::CreateDefault() { // Explicit new, to access non-public constructor. - return rtc::scoped_refptr(new SharedScreenCastStream()); + return rtc::scoped_refptr( + new SharedScreenCastStream()); } bool SharedScreenCastStream::StartScreenCastStream(uint32_t stream_node_id) {