From cfab6409ae8de8c9075708593c4c187fca94ea8f Mon Sep 17 00:00:00 2001 From: Mirko Bonadei Date: Fri, 7 Jun 2024 10:16:53 +0000 Subject: [PATCH] Skip tests failing with the new version of UBSan. Bug: webrtc:345674542 Change-Id: I24171a6452e66e48683f3edfdde35322e0fe4b8a Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/353940 Reviewed-by: Henrik Lundin Auto-Submit: Mirko Bonadei Commit-Queue: Henrik Lundin Commit-Queue: Mirko Bonadei Cr-Commit-Position: refs/heads/main@{#42448} --- common_audio/vad/vad_core_unittest.cc | 5 +++++ common_audio/vad/vad_unittest.cc | 5 +++++ 2 files changed, 10 insertions(+) diff --git a/common_audio/vad/vad_core_unittest.cc b/common_audio/vad/vad_core_unittest.cc index 3131a86ae3..186ffa5e70 100644 --- a/common_audio/vad/vad_core_unittest.cc +++ b/common_audio/vad/vad_core_unittest.cc @@ -54,7 +54,12 @@ TEST_F(VadTest, set_mode_core) { free(self); } +// TODO(bugs.webrtc.org/345674542): Fix/enable. +#if defined(__has_feature) && __has_feature(undefined_behavior_sanitizer) +TEST_F(VadTest, DISABLED_CalcVad) { +#else TEST_F(VadTest, CalcVad) { +#endif VadInstT* self = reinterpret_cast(malloc(sizeof(VadInstT))); int16_t speech[kMaxFrameLength]; diff --git a/common_audio/vad/vad_unittest.cc b/common_audio/vad/vad_unittest.cc index c54014efce..1cdc3d9fde 100644 --- a/common_audio/vad/vad_unittest.cc +++ b/common_audio/vad/vad_unittest.cc @@ -54,7 +54,12 @@ bool VadTest::ValidRatesAndFrameLengths(int rate, size_t frame_length) { namespace webrtc { namespace test { +// TODO(bugs.webrtc.org/345674542): Fix/enable. +#if defined(__has_feature) && __has_feature(undefined_behavior_sanitizer) +TEST_F(VadTest, DISABLED_ApiTest) { +#else TEST_F(VadTest, ApiTest) { +#endif // This API test runs through the APIs for all possible valid and invalid // combinations.