From eeacddbd997fa280c49eedf37c47925c764fb708 Mon Sep 17 00:00:00 2001 From: Jeremy Leconte Date: Fri, 2 Jun 2023 08:45:02 +0200 Subject: [PATCH] Disable flaky PictureIdTests. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit See https://ci.chromium.org/p/webrtc/builders/try/fuchsia_rel Change-Id: I5be36c24e3139e10620572dfe9d6647f7ef3426a Bug: webrtc:14985 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/307462 Commit-Queue: Jeremy Leconte Reviewed-by: Erik Språng Cr-Commit-Position: refs/heads/main@{#40201} --- video/picture_id_tests.cc | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/video/picture_id_tests.cc b/video/picture_id_tests.cc index 6caec13068..09bc22221a 100644 --- a/video/picture_id_tests.cc +++ b/video/picture_id_tests.cc @@ -368,7 +368,8 @@ TEST_P(PictureIdTest, ContinuousAfterReconfigureVp8) { TestPictureIdContinuousAfterReconfigure({1, 3, 3, 1, 1}); } -TEST_P(PictureIdTest, IncreasingAfterRecreateStreamVp8) { +// TODO(bugs.webrtc.org/14985): Investigate and reenable. +TEST_P(PictureIdTest, DISABLED_IncreasingAfterRecreateStreamVp8) { test::FunctionVideoEncoderFactory encoder_factory( []() { return VP8Encoder::Create(); }); SetupEncoder(&encoder_factory, "VP8"); @@ -395,7 +396,9 @@ TEST_P(PictureIdTest, ContinuousAfterReconfigureSimulcastEncoderAdapter) { TestPictureIdContinuousAfterReconfigure({1, 3, 3, 1, 1}); } -TEST_P(PictureIdTest, IncreasingAfterRecreateStreamSimulcastEncoderAdapter) { +// TODO(bugs.webrtc.org/14985): Investigate and reenable. +TEST_P(PictureIdTest, + DISABLED_IncreasingAfterRecreateStreamSimulcastEncoderAdapter) { InternalEncoderFactory internal_encoder_factory; test::FunctionVideoEncoderFactory encoder_factory( [&internal_encoder_factory]() { @@ -419,7 +422,8 @@ TEST_P(PictureIdTest, ContinuousAfterStreamCountChangeSimulcastEncoderAdapter) { TestPictureIdContinuousAfterReconfigure({3, 1, 3}); } -TEST_P(PictureIdTest, IncreasingAfterRecreateStreamVp9) { +// TODO(bugs.webrtc.org/14985): Investigate and reenable. +TEST_P(PictureIdTest, DISABLED_IncreasingAfterRecreateStreamVp9) { test::FunctionVideoEncoderFactory encoder_factory( []() { return VP9Encoder::Create(); }); SetupEncoder(&encoder_factory, "VP9");