diff --git a/BUILD.gn b/BUILD.gn index 5c3ef433bd..31e130a98e 100644 --- a/BUILD.gn +++ b/BUILD.gn @@ -454,11 +454,6 @@ rtc_source_set("webrtc_common") { "rtc_base:checks", "//third_party/abseil-cpp/absl/strings", ] - - if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } } if (use_libfuzzer || use_drfuzz || use_afl) { @@ -564,10 +559,6 @@ if (rtc_include_tests) { "video:video_tests", ] data = video_engine_tests_resources - if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } if (is_android) { deps += [ "//testing/android/native_test:native_test_native_code" ] shard_timeout = 900 diff --git a/api/BUILD.gn b/api/BUILD.gn index 9e2bc9171e..2a86b0a93c 100644 --- a/api/BUILD.gn +++ b/api/BUILD.gn @@ -186,10 +186,6 @@ rtc_source_set("video_quality_test_fixture_api") { "../test:video_test_common", "video_codecs:video_codecs_api", ] - if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } } rtc_source_set("test_dependency_factory") { @@ -205,10 +201,6 @@ rtc_source_set("test_dependency_factory") { "../rtc_base:thread_checker", "//third_party/abseil-cpp/absl/memory", ] - if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } } if (rtc_include_tests) { @@ -226,10 +218,6 @@ if (rtc_include_tests) { "../video:video_quality_test", "//third_party/abseil-cpp/absl/memory", ] - if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } } } @@ -429,10 +417,6 @@ if (rtc_include_tests) { "video_codecs:video_codecs_api", "//third_party/abseil-cpp/absl/memory", ] - if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } } rtc_source_set("videocodec_test_fixture_api") { @@ -466,10 +450,6 @@ if (rtc_include_tests) { "video_codecs:video_codecs_api", "//third_party/abseil-cpp/absl/memory", ] - if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } } rtc_source_set("mock_audio_mixer") { @@ -670,11 +650,6 @@ if (rtc_include_tests) { "test/loopback_media_transport_unittest.cc", ] - if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } - deps = [ ":array_view", ":libjingle_peerconnection_api", diff --git a/api/video/BUILD.gn b/api/video/BUILD.gn index 7fd0790075..0b71df4488 100644 --- a/api/video/BUILD.gn +++ b/api/video/BUILD.gn @@ -204,11 +204,6 @@ rtc_source_set("video_stream_encoder_create") { "video_stream_encoder_create.h", ] - if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } - deps = [ ":video_frame", ":video_stream_encoder", diff --git a/api/video_codecs/BUILD.gn b/api/video_codecs/BUILD.gn index b45470ced3..3ccded86c1 100644 --- a/api/video_codecs/BUILD.gn +++ b/api/video_codecs/BUILD.gn @@ -122,11 +122,6 @@ rtc_static_library("rtc_software_fallback_wrappers") { "video_encoder_software_fallback_wrapper.h", ] - if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } - deps = [ ":video_codecs_api", "../../:webrtc_common", diff --git a/audio/BUILD.gn b/audio/BUILD.gn index 80ce0998f9..3a1d12316d 100644 --- a/audio/BUILD.gn +++ b/audio/BUILD.gn @@ -37,11 +37,6 @@ rtc_static_library("audio") { "transport_feedback_packet_loss_tracker.h", ] - if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } - deps = [ "../api:array_view", "../api:call_api", @@ -106,11 +101,6 @@ if (rtc_include_tests) { "../test:test_support", "//third_party/abseil-cpp/absl/memory", ] - - if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } } rtc_source_set("audio_tests") { @@ -175,11 +165,6 @@ if (rtc_include_tests) { "//testing/gtest", "//third_party/abseil-cpp/absl/memory", ] - - if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } } if (rtc_enable_protobuf) { @@ -209,11 +194,6 @@ if (rtc_include_tests) { "../resources/voice_engine/audio_tiny16.wav", "../resources/voice_engine/audio_tiny48.wav", ] - - if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163) - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } } group("low_bandwidth_audio_perf_test") { @@ -283,10 +263,5 @@ if (rtc_include_tests) { data = [ "//resources/voice_engine/audio_dtx16.wav", ] - - if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } } } diff --git a/audio/utility/BUILD.gn b/audio/utility/BUILD.gn index 50c447521b..f60b51265f 100644 --- a/audio/utility/BUILD.gn +++ b/audio/utility/BUILD.gn @@ -42,9 +42,5 @@ if (rtc_include_tests) { "../../test:test_support", "//testing/gtest", ] - if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } } } diff --git a/call/BUILD.gn b/call/BUILD.gn index 210931cf86..cfaae1da49 100644 --- a/call/BUILD.gn +++ b/call/BUILD.gn @@ -400,10 +400,6 @@ if (rtc_include_tests) { "//third_party/abseil-cpp/absl/memory", "//third_party/abseil-cpp/absl/types:optional", ] - if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } } rtc_source_set("call_perf_tests") { @@ -446,10 +442,6 @@ if (rtc_include_tests) { "//testing/gtest", "//third_party/abseil-cpp/absl/memory", ] - if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } } # TODO(eladalon): This should be moved, as with the TODO for |rtp_interfaces|. diff --git a/examples/BUILD.gn b/examples/BUILD.gn index f8b5489484..427ddb6d52 100644 --- a/examples/BUILD.gn +++ b/examples/BUILD.gn @@ -497,11 +497,6 @@ if (is_ios || (is_mac && target_cpu != "x86")) { "objcnativeapi/objc/objc_call_client.mm", ] - if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } - deps = [ "../api:libjingle_peerconnection_api", "../api:scoped_refptr", @@ -685,10 +680,6 @@ if (is_linux || is_win) { "peerconnection/client/peer_connection_client.h", ] - if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } deps = [ "../api:audio_options_api", "../api:create_peerconnection_factory", @@ -772,10 +763,6 @@ if (is_linux || is_win) { "../system_wrappers:field_trial", "../test:field_trial", ] - if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } } rtc_executable("relayserver") { testonly = true @@ -789,10 +776,6 @@ if (is_linux || is_win) { "../rtc_base:rtc_base", "../rtc_base:rtc_base_approved", ] - if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } } rtc_executable("turnserver") { testonly = true @@ -807,10 +790,6 @@ if (is_linux || is_win) { "../rtc_base:rtc_base", "../rtc_base:rtc_base_approved", ] - if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } } rtc_executable("stunserver") { testonly = true @@ -824,10 +803,6 @@ if (is_linux || is_win) { "../rtc_base:rtc_base", "../rtc_base:rtc_base_approved", ] - if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } } } @@ -852,10 +827,6 @@ if (is_win || is_android) { suppressed_configs += [ "//build/config/android:hide_all_but_jni_onload" ] } - if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } if (is_win) { configs += [ "//build/config/win:windowed" ] } @@ -925,13 +896,6 @@ if (!build_with_chromium) { sources = [ "stunprober/main.cc", ] - - if (!build_with_chromium && is_clang) { - # Suppress warnings from Chrome's Clang plugins. - # See http://code.google.com/p/webrtc/issues/detail?id=163 for details. - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } - deps = [ "../p2p:libstunprober", "../p2p:rtc_p2p", diff --git a/logging/BUILD.gn b/logging/BUILD.gn index b50d94015a..694f90e851 100644 --- a/logging/BUILD.gn +++ b/logging/BUILD.gn @@ -38,9 +38,9 @@ rtc_source_set("rtc_event_log_api") { ] deps = [ - "../api/task_queue", "../api:libjingle_logging_api", "../api:scoped_refptr", + "../api/task_queue", "../rtc_base:rtc_base_approved", "//third_party/abseil-cpp/absl/memory", ] @@ -129,9 +129,6 @@ rtc_source_set("rtc_event_generic_packet_events") { ":rtc_event_log_api", "//third_party/abseil-cpp/absl/memory", ] - if (!build_with_chromium && is_clang) { - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } } rtc_source_set("rtc_event_rtp_rtcp") { @@ -226,10 +223,6 @@ rtc_static_library("rtc_event_log_impl_encoder") { "rtc_event_log/encoder/rtc_event_log_encoder_new_format.cc", "rtc_event_log/encoder/rtc_event_log_encoder_new_format.h", ] - - if (!build_with_chromium && is_clang) { - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } } } @@ -262,8 +255,8 @@ rtc_static_library("rtc_event_log_impl_base") { deps = [ ":ice_log", ":rtc_event_log_api", - "../api/task_queue:global_task_queue_factory", "../api:libjingle_logging_api", + "../api/task_queue:global_task_queue_factory", "../rtc_base:checks", "../rtc_base:rtc_base_approved", "../rtc_base:rtc_task_queue", @@ -350,10 +343,6 @@ if (rtc_enable_protobuf) { "//third_party/abseil-cpp/absl/memory", "//third_party/abseil-cpp/absl/types:optional", ] - - if (!build_with_chromium && is_clang) { - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } } if (rtc_include_tests) { @@ -405,10 +394,6 @@ if (rtc_enable_protobuf) { "//third_party/abseil-cpp/absl/memory", "//third_party/abseil-cpp/absl/types:optional", ] - if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } } rtc_test("rtc_event_log2rtp_dump") { @@ -430,10 +415,6 @@ if (rtc_enable_protobuf) { "//third_party/abseil-cpp/absl/memory", "//third_party/abseil-cpp/absl/types:optional", ] - if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } } } } diff --git a/media/BUILD.gn b/media/BUILD.gn index ccbfd38506..8316603b9c 100644 --- a/media/BUILD.gn +++ b/media/BUILD.gn @@ -30,11 +30,6 @@ rtc_source_set("rtc_h264_profile_id") { "base/h264_profile_level_id.h", ] - if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } - deps = [ "..:webrtc_common", "../rtc_base:checks", @@ -115,11 +110,6 @@ rtc_static_library("rtc_media_base") { "base/video_source_base.h", ] - if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } - deps += [ ":rtc_h264_profile_id", ":rtc_media_config", @@ -187,10 +177,6 @@ rtc_static_library("rtc_simulcast_encoder_adapter") { "//third_party/abseil-cpp/absl/types:optional", "//third_party/libyuv", ] - if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } } rtc_static_library("rtc_encoder_simulcast_proxy") { @@ -209,10 +195,6 @@ rtc_static_library("rtc_encoder_simulcast_proxy") { "../api/video_codecs:video_codecs_api", "../modules/video_coding:video_codec_interface", ] - if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } } rtc_static_library("rtc_internal_video_codecs") { @@ -245,11 +227,6 @@ rtc_static_library("rtc_internal_video_codecs") { "engine/encoder_simulcast_proxy.h", ] - if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } - include_dirs = [] public_configs = [] @@ -317,11 +294,6 @@ rtc_static_library("rtc_audio_video") { "engine/webrtc_voice_engine.h", ] - if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } - include_dirs = [] public_configs = [] @@ -390,11 +362,6 @@ rtc_static_library("rtc_data") { ] } - if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } - if (rtc_enable_sctp && rtc_build_usrsctp) { include_dirs = [ # TODO(jiayl): move this into the public_configs of @@ -474,11 +441,6 @@ if (rtc_include_tests) { "engine/fake_webrtc_video_engine.h", ] - if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } - deps += [ ":rtc_internal_video_codecs", ":rtc_media", @@ -586,13 +548,6 @@ if (rtc_include_tests) { defines += [ "WEBRTC_OPUS_SUPPORT_120MS_PTIME=0" ] } - if (!build_with_chromium && is_clang) { - suppressed_configs += [ - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). - "//build/config/clang:find_bad_constructs", - ] - } - data = rtc_media_unittests_resources if (is_android) { diff --git a/modules/audio_coding/BUILD.gn b/modules/audio_coding/BUILD.gn index 55b5078cea..5a47245c49 100644 --- a/modules/audio_coding/BUILD.gn +++ b/modules/audio_coding/BUILD.gn @@ -900,11 +900,6 @@ rtc_static_library("audio_network_adaptor") { ":ana_debug_dump_proto", ] } - - if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } } rtc_static_library("neteq") { @@ -1063,11 +1058,6 @@ rtc_source_set("neteq_test_tools") { "neteq/tools/rtp_generator.h", ] - if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } - deps = [ ":pcm16b", "../..:webrtc_common", @@ -1113,11 +1103,6 @@ rtc_source_set("neteq_tools") { "neteq/tools/neteq_stats_plotter.h", ] - if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } - deps = [ "..:module_api", "../..:webrtc_common", @@ -1163,11 +1148,6 @@ if (rtc_enable_protobuf) { "neteq/tools/rtc_event_log_source.h", ] - if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } - deps = [ ":neteq_tools_minimal", "../../logging:rtc_event_log_parser", @@ -1325,10 +1305,6 @@ if (rtc_include_tests) { "//third_party/abseil-cpp/absl/types:optional", ] defines = audio_coding_defines - if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } } rtc_source_set("audio_coding_perf_tests") { @@ -1351,11 +1327,6 @@ if (rtc_include_tests) { "../../test:perf_test", "../../test:test_support", ] - - if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } } rtc_source_set("acm_receive_test") { @@ -1474,11 +1445,6 @@ if (rtc_include_tests) { "neteq/tools/neteq_test_factory.h", ] - if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } - deps += [ ":neteq", ":neteq_test_tools", @@ -1536,11 +1502,6 @@ if (rtc_include_tests) { "codecs/tools/audio_codec_speed_test.h", ] - if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } - data = audio_codec_speed_tests_resources if (is_android) { @@ -1572,11 +1533,6 @@ if (rtc_include_tests) { "neteq/tools/neteq_performance_test.h", ] - if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } - deps = [ ":neteq", ":neteq_test_tools", @@ -1601,11 +1557,6 @@ if (rtc_include_tests) { "neteq/tools/neteq_quality_test.h", ] - if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } - deps = [ ":neteq", ":neteq_test_tools", @@ -2074,11 +2025,6 @@ if (rtc_include_tests) { ":neteq_unittest_proto", ] } - - if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } } } diff --git a/modules/audio_device/BUILD.gn b/modules/audio_device/BUILD.gn index f982196742..8c13c5b7f6 100644 --- a/modules/audio_device/BUILD.gn +++ b/modules/audio_device/BUILD.gn @@ -84,10 +84,6 @@ if (rtc_include_internal_audio_device && is_ios) { "../../sdk:base_objc", "../../system_wrappers:metrics", ] - if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } } } @@ -104,10 +100,6 @@ rtc_source_set("audio_device_api") { "../../rtc_base:rtc_base_approved", "../../rtc_base:stringutils", ] - if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } } rtc_source_set("audio_device_buffer") { @@ -128,10 +120,6 @@ rtc_source_set("audio_device_buffer") { "../../system_wrappers", "../../system_wrappers:metrics", ] - if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } } rtc_source_set("audio_device_generic") { @@ -144,10 +132,6 @@ rtc_source_set("audio_device_generic") { ":audio_device_buffer", "../../rtc_base:rtc_base_approved", ] - if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } } rtc_source_set("audio_device_name") { @@ -389,11 +373,6 @@ rtc_source_set("audio_device_impl") { "dummy/file_audio_device_factory.h", ] } - - if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } } rtc_source_set("mock_audio_device") { @@ -435,10 +414,6 @@ if (rtc_include_tests) { "../../test:test_support", "//third_party/ocmock", ] - if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } } } @@ -493,10 +468,6 @@ if (rtc_include_tests) { "../../sdk/android:libjingle_peerconnection_java", ] } - if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } if (!rtc_include_internal_audio_device) { defines = [ "WEBRTC_DUMMY_AUDIO_BUILD" ] } diff --git a/modules/audio_processing/BUILD.gn b/modules/audio_processing/BUILD.gn index 6fc7d86cf3..a54b4598b7 100644 --- a/modules/audio_processing/BUILD.gn +++ b/modules/audio_processing/BUILD.gn @@ -506,11 +506,6 @@ if (rtc_include_tests) { "voice_detection_unittest.cc", ] } - - if ((!build_with_chromium || is_win) && is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } } rtc_source_set("audio_processing_perf_tests") { diff --git a/modules/audio_processing/agc/BUILD.gn b/modules/audio_processing/agc/BUILD.gn index a5c15ecbbc..4c0e768940 100644 --- a/modules/audio_processing/agc/BUILD.gn +++ b/modules/audio_processing/agc/BUILD.gn @@ -108,11 +108,6 @@ if (rtc_include_tests) { ] configs += [ "..:apm_debug_dump" ] - if ((!build_with_chromium || is_win) && is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } - deps = [ ":agc", ":level_estimation", diff --git a/modules/bitrate_controller/BUILD.gn b/modules/bitrate_controller/BUILD.gn index 1302326c4b..0767c56ace 100644 --- a/modules/bitrate_controller/BUILD.gn +++ b/modules/bitrate_controller/BUILD.gn @@ -26,10 +26,6 @@ rtc_static_library("bitrate_controller") { } else { defines = [ "BWE_TEST_LOGGING_COMPILE_TIME_ENABLE=0" ] } - if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } deps = [ "..:module_api", @@ -89,9 +85,5 @@ if (rtc_include_tests) { "../remote_bitrate_estimator:remote_bitrate_estimator", "../rtp_rtcp:rtp_rtcp_format", ] - if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } } } diff --git a/modules/congestion_controller/BUILD.gn b/modules/congestion_controller/BUILD.gn index 7c683d460d..194464d7ee 100644 --- a/modules/congestion_controller/BUILD.gn +++ b/modules/congestion_controller/BUILD.gn @@ -28,11 +28,6 @@ rtc_static_library("congestion_controller") { "send_side_congestion_controller.cc", ] - if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } - deps = [ ":transport_feedback", "..:module_api", @@ -93,10 +88,6 @@ if (rtc_include_tests) { "test/controller_printer.cc", "test/controller_printer.h", ] - if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } deps = [ "../../api/transport:network_control", "../../api/units:data_rate", @@ -140,10 +131,6 @@ if (rtc_include_tests) { "pcc:pcc_unittests", "rtp:congestion_controller_unittests", ] - if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } } rtc_source_set("mock_congestion_controller") { diff --git a/modules/congestion_controller/bbr/BUILD.gn b/modules/congestion_controller/bbr/BUILD.gn index a6183be3d2..7e321345f9 100644 --- a/modules/congestion_controller/bbr/BUILD.gn +++ b/modules/congestion_controller/bbr/BUILD.gn @@ -160,9 +160,5 @@ if (rtc_include_tests) { "../../../test:test_support", "../../../test/scenario", ] - if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } } } diff --git a/modules/congestion_controller/goog_cc/BUILD.gn b/modules/congestion_controller/goog_cc/BUILD.gn index f837cad93b..326571e804 100644 --- a/modules/congestion_controller/goog_cc/BUILD.gn +++ b/modules/congestion_controller/goog_cc/BUILD.gn @@ -224,9 +224,6 @@ if (rtc_include_tests) { "probe_controller_unittest.cc", "trendline_estimator_unittest.cc", ] - if (!build_with_chromium && is_clang) { - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } deps = [ ":alr_detector", ":delay_based_bwe", @@ -263,9 +260,6 @@ if (rtc_include_tests) { sources = [ "goog_cc_network_control_slowtest.cc", ] - if (!build_with_chromium && is_clang) { - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } deps = [ ":alr_detector", ":delay_based_bwe", diff --git a/modules/congestion_controller/pcc/BUILD.gn b/modules/congestion_controller/pcc/BUILD.gn index dbb0826226..a0b3f2b8a4 100644 --- a/modules/congestion_controller/pcc/BUILD.gn +++ b/modules/congestion_controller/pcc/BUILD.gn @@ -129,9 +129,5 @@ if (rtc_include_tests) { "../../../test/scenario", "//third_party/abseil-cpp/absl/memory", ] - if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } } } diff --git a/modules/congestion_controller/rtp/BUILD.gn b/modules/congestion_controller/rtp/BUILD.gn index 7330572e6f..ce792105a1 100644 --- a/modules/congestion_controller/rtp/BUILD.gn +++ b/modules/congestion_controller/rtp/BUILD.gn @@ -98,9 +98,5 @@ if (rtc_include_tests) { "../../rtp_rtcp:rtp_rtcp_format", "//testing/gmock", ] - if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } } } diff --git a/modules/remote_bitrate_estimator/BUILD.gn b/modules/remote_bitrate_estimator/BUILD.gn index cf23fb0001..43315d3b95 100644 --- a/modules/remote_bitrate_estimator/BUILD.gn +++ b/modules/remote_bitrate_estimator/BUILD.gn @@ -177,10 +177,6 @@ if (rtc_include_tests) { "../../test:fileutils", "../../test:test_support", ] - if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } } rtc_source_set("remote_bitrate_estimator_unittests") { @@ -218,10 +214,6 @@ if (rtc_include_tests) { "../pacing:pacing", "../rtp_rtcp:rtp_rtcp_format", ] - if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } } rtc_test("bwe_simulations_tests") { @@ -246,10 +238,5 @@ if (rtc_include_tests) { "//resources/verizon4g-downlink.rx", "//resources/google-wifi-3mbps.rx", ] - - if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } } } diff --git a/modules/video_coding/BUILD.gn b/modules/video_coding/BUILD.gn index 7c027c4526..ffd58a24eb 100644 --- a/modules/video_coding/BUILD.gn +++ b/modules/video_coding/BUILD.gn @@ -31,11 +31,6 @@ rtc_static_library("encoded_frame") { "//third_party/abseil-cpp/absl/types:optional", "//third_party/abseil-cpp/absl/types:variant", ] - - if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } } rtc_static_library("nack_module") { @@ -47,11 +42,6 @@ rtc_static_library("nack_module") { "nack_module.h", ] - if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } - deps = [ ":packet", "..:module_api", @@ -151,11 +141,6 @@ rtc_static_library("video_coding") { "video_receiver.cc", ] - if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } - deps += [ ":codec_globals_headers", ":encoded_frame", @@ -254,11 +239,6 @@ rtc_source_set("video_coding_utility") { "utility/vp9_uncompressed_header_parser.h", ] - if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } - deps = [ ":video_codec_interface", "..:module_api", @@ -294,11 +274,6 @@ rtc_static_library("webrtc_h264") { "codecs/h264/include/h264.h", ] - if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } - defines = [] deps = [ ":video_codec_interface", @@ -353,11 +328,6 @@ rtc_static_library("webrtc_multiplex") { "codecs/multiplex/multiplex_encoder_adapter.cc", ] - if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } - deps = [ ":video_codec_interface", ":video_coding_utility", @@ -390,11 +360,6 @@ rtc_static_library("webrtc_vp8") { "codecs/vp8/libvpx_vp8_encoder.h", ] - if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } - deps = [ ":codec_globals_headers", ":video_codec_interface", @@ -439,11 +404,6 @@ rtc_static_library("webrtc_vp8_temporal_layers") { "codecs/vp8/temporal_layers_checker.cc", ] - if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } - deps = [ ":codec_globals_headers", ":video_codec_interface", @@ -471,11 +431,6 @@ rtc_static_library("webrtc_vp9_helpers") { "codecs/vp9/svc_rate_allocator.h", ] - if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } - deps = [ ":codec_globals_headers", ":video_codec_interface", @@ -500,11 +455,6 @@ rtc_static_library("webrtc_vp9") { "codecs/vp9/vp9_impl.h", ] - if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } - deps = [ ":video_codec_interface", ":video_coding_utility", @@ -571,11 +521,6 @@ if (rtc_include_tests) { "../../sdk:videosource_objc", "../../sdk:videotoolbox_objc", ] - - if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } } } @@ -586,11 +531,6 @@ if (rtc_include_tests) { "utility/simulcast_test_fixture_impl.h", ] - if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } - deps = [ ":video_codec_interface", ":video_coding", @@ -620,11 +560,6 @@ if (rtc_include_tests) { "codecs/test/videoprocessor.h", ] - if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } - deps = [ ":codec_globals_headers", ":video_codec_interface", @@ -735,10 +670,6 @@ if (rtc_include_tests) { "//third_party/abseil-cpp/absl/memory", "//third_party/abseil-cpp/absl/types:optional", ] - if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } } rtc_source_set("video_coding_modules_tests") { @@ -817,11 +748,6 @@ if (rtc_include_tests) { } } - if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } - if (rtc_build_libvpx) { deps += [ rtc_libvpx_dir ] } @@ -938,9 +864,5 @@ if (rtc_include_tests) { if (rtc_build_libvpx) { deps += [ rtc_libvpx_dir ] } - if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } } } diff --git a/modules/video_processing/BUILD.gn b/modules/video_processing/BUILD.gn index afcbf7f33d..84ce3b7745 100644 --- a/modules/video_processing/BUILD.gn +++ b/modules/video_processing/BUILD.gn @@ -45,11 +45,6 @@ rtc_static_library("video_processing") { if (rtc_build_with_neon) { deps += [ ":video_processing_neon" ] } - - if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } } rtc_source_set("denoiser_filter") { @@ -76,11 +71,6 @@ if (build_video_processing_sse2) { "../../system_wrappers", ] - if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } - if (is_posix || is_fuchsia) { cflags = [ "-msse2" ] } @@ -123,9 +113,5 @@ if (rtc_include_tests) { "../../test:test_support", "../../test:video_test_common", ] - if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } } } diff --git a/p2p/BUILD.gn b/p2p/BUILD.gn index 05e342f458..7340a031f8 100644 --- a/p2p/BUILD.gn +++ b/p2p/BUILD.gn @@ -210,10 +210,6 @@ if (rtc_include_tests) { "//third_party/abseil-cpp/absl/algorithm:container", "//third_party/abseil-cpp/absl/memory", ] - if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } } } diff --git a/pc/BUILD.gn b/pc/BUILD.gn index b20f064672..90cb11febb 100644 --- a/pc/BUILD.gn +++ b/pc/BUILD.gn @@ -109,11 +109,6 @@ rtc_static_library("rtc_pc_base") { } public_configs = [ ":rtc_pc_config" ] - - if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } } rtc_source_set("rtc_pc") { @@ -194,11 +189,6 @@ rtc_static_library("peerconnection") { "webrtc_session_description_factory.h", ] - if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } - deps = [ ":rtc_pc_base", "..:webrtc_common", @@ -271,11 +261,6 @@ if (rtc_include_tests) { include_dirs = [ "//third_party/libsrtp/srtp" ] - if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } - if (is_win) { libs = [ "strmiids.lib" ] } @@ -357,10 +342,6 @@ if (rtc_include_tests) { "//third_party/abseil-cpp/absl/memory", "//third_party/abseil-cpp/absl/types:optional", ] - if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } } rtc_source_set("peerconnection_wrapper") { @@ -380,10 +361,6 @@ if (rtc_include_tests) { "../rtc_base:rtc_base_approved", "../test:test_support", ] - if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } } rtc_source_set("pc_test_utils") { @@ -452,11 +429,6 @@ if (rtc_include_tests) { "//third_party/abseil-cpp/absl/memory", "//third_party/abseil-cpp/absl/types:optional", ] - - if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } } rtc_test("peerconnection_unittests") { @@ -507,11 +479,6 @@ if (rtc_include_tests) { defines = [ "HAVE_SCTP" ] } - if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } - deps = [ ":peerconnection", ":rtc_pc_base", diff --git a/rtc_tools/BUILD.gn b/rtc_tools/BUILD.gn index f9096507d7..08e9c27f8d 100644 --- a/rtc_tools/BUILD.gn +++ b/rtc_tools/BUILD.gn @@ -192,10 +192,6 @@ if (!build_with_chromium) { "../test:video_test_common", "//third_party/abseil-cpp/absl/strings", ] - if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } } rtc_executable("psnr_ssim_analyzer") { @@ -297,10 +293,6 @@ if (!build_with_chromium) { "event_log_visualizer/plot_python.h", "event_log_visualizer/triage_notifications.h", ] - if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } defines = [ "ENABLE_RTC_EVENT_LOG" ] deps = [ ":chart_proto", @@ -346,11 +338,6 @@ if (rtc_include_tests) { "event_log_visualizer/main.cc", ] - if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } - defines = [ "ENABLE_RTC_EVENT_LOG" ] deps = [ ":event_log_visualizer_utils", @@ -419,11 +406,6 @@ if (rtc_include_tests) { "video_file_writer_unittest.cc", ] - if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } - deps = [ ":command_line_parser", ":video_file_reader", diff --git a/rtc_tools/network_tester/BUILD.gn b/rtc_tools/network_tester/BUILD.gn index 70c15bbb25..bd1a64bf05 100644 --- a/rtc_tools/network_tester/BUILD.gn +++ b/rtc_tools/network_tester/BUILD.gn @@ -53,11 +53,6 @@ if (rtc_enable_protobuf) { "../../rtc_base/third_party/sigslot:sigslot", "//third_party/abseil-cpp/absl/types:optional", ] - - if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } } network_tester_unittests_resources = [ @@ -97,11 +92,6 @@ if (rtc_enable_protobuf) { defines = [ "WEBRTC_NETWORK_TESTER_TEST_ENABLED" ] data = network_tester_unittests_resources - - if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } } rtc_executable("network_tester_server") { @@ -112,11 +102,6 @@ if (rtc_enable_protobuf) { deps = [ ":network_tester", ] - - if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } } } diff --git a/sdk/BUILD.gn b/sdk/BUILD.gn index 5ffd96477f..03cf0c4133 100644 --- a/sdk/BUILD.gn +++ b/sdk/BUILD.gn @@ -238,12 +238,6 @@ if (is_ios || is_mac) { "../rtc_base:rtc_base_approved", "../system_wrappers", ] - - if (is_clang) { - # Suppress warnings from the Chromium Clang plugin - # (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } } rtc_source_set("audio_session_observer") { @@ -287,12 +281,6 @@ if (is_ios || is_mac) { ] libs = [ "AudioToolbox.framework" ] - - if (is_clang) { - # Suppress warnings from the Chromium Clang plugin - # (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } } rtc_static_library("audio_objc") { @@ -565,11 +553,7 @@ if (is_ios || is_mac) { "objc/components/video_codec/UIDevice+H264Profile.mm", ] } - if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin - # (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } + public_configs = [ ":common_config_objc" ] deps = [ ":base_objc", @@ -775,12 +759,6 @@ if (is_ios || is_mac) { "../modules/video_coding:video_codec_interface", "../rtc_base:rtc_base", ] - - if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin - # (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } } rtc_static_library("peerconnectionfactory_base_objc") { @@ -1589,12 +1567,6 @@ if (is_ios || is_mac) { public_configs = [ ":common_config_objc" ] - if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin - # (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } - deps = [ ":base_native_additions_objc", ":base_objc", diff --git a/sdk/android/BUILD.gn b/sdk/android/BUILD.gn index 94277aa7d5..c116535365 100644 --- a/sdk/android/BUILD.gn +++ b/sdk/android/BUILD.gn @@ -1507,11 +1507,6 @@ if (is_android) { "../../resources/audio_device/audio_short48.pcm", ] - if (is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } - deps = [ ":audio_device_module_base", ":audio_jni", diff --git a/test/BUILD.gn b/test/BUILD.gn index 39d99c1ffc..de69a1b6f8 100644 --- a/test/BUILD.gn +++ b/test/BUILD.gn @@ -54,11 +54,6 @@ rtc_source_set("video_test_common") { "video_codec_settings.h", ] - if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } - deps = [ "..:webrtc_common", "../api:libjingle_peerconnection_api", @@ -94,11 +89,6 @@ rtc_source_set("rtp_test_utils") { "rtp_file_writer.h", ] - if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } - deps = [ "..:webrtc_common", "../api:array_view", @@ -206,11 +196,6 @@ rtc_source_set("test_support") { "//testing/gmock", "//testing/gtest", ] - - if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } } if (rtc_include_tests) { @@ -291,11 +276,6 @@ if (rtc_include_tests) { sources += [ "testsupport/jpeg_frame_writer_ios.cc" ] } - if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } - if (is_android) { deps += [ "//base:base" ] } @@ -388,11 +368,6 @@ if (rtc_include_tests) { "testsupport/yuv_frame_writer_unittest.cc", ] - if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } - data = test_support_unittests_resources if (is_android) { deps += [ "//testing/android/native_test:native_test_support" ] @@ -573,10 +548,6 @@ rtc_source_set("direct_transport") { "direct_transport.cc", "direct_transport.h", ] - if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } deps = [ "..:webrtc_common", "../api:simulated_network_api", @@ -623,10 +594,6 @@ rtc_source_set("fake_video_codecs") { "fake_vp8_encoder.cc", "fake_vp8_encoder.h", ] - if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } deps = [ "..:webrtc_common", "../api:scoped_refptr", @@ -689,11 +656,6 @@ rtc_source_set("test_common") { ] } - if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } - deps = [ ":direct_transport", ":fake_video_codecs", @@ -782,10 +744,6 @@ if (is_mac) { "OpenGL.framework", "CoreVideo.framework", ] - if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } } } @@ -841,11 +799,6 @@ rtc_source_set("test_renderer_generic") { "log", ] } - - if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } } rtc_source_set("audio_codec_mocks") { diff --git a/test/fuzzers/BUILD.gn b/test/fuzzers/BUILD.gn index 6e723e1548..a7f2b68a6e 100644 --- a/test/fuzzers/BUILD.gn +++ b/test/fuzzers/BUILD.gn @@ -53,7 +53,6 @@ template("webrtc_fuzzer_test") { "../../rtc_base:rtc_task_queue_impl", ] if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). suppressed_configs = [ "//build/config/clang:find_bad_constructs" ] } } diff --git a/test/pc/e2e/BUILD.gn b/test/pc/e2e/BUILD.gn index 017c78301f..62d2b26df7 100644 --- a/test/pc/e2e/BUILD.gn +++ b/test/pc/e2e/BUILD.gn @@ -193,10 +193,6 @@ if (rtc_include_tests) { "//third_party/abseil-cpp/absl/memory:memory", "//third_party/abseil-cpp/absl/types:optional", ] - if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } } rtc_source_set("peerconnection_quality_test") { @@ -233,10 +229,6 @@ if (rtc_include_tests) { "api:video_quality_analyzer_api", "//third_party/abseil-cpp/absl/memory:memory", ] - if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } } rtc_source_set("single_process_encoded_image_data_injector_unittest") { @@ -300,11 +292,6 @@ if (rtc_include_tests) { "api:peer_connection_quality_test_fixture_api", "//third_party/abseil-cpp/absl/memory:memory", ] - - if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } } rtc_source_set("stats_poller") { @@ -319,10 +306,6 @@ if (rtc_include_tests) { "../../../rtc_base:logging", "api:stats_observer_interface", ] - if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } } } @@ -384,9 +367,4 @@ rtc_source_set("default_video_quality_analyzer") { "api:video_quality_analyzer_api", "//third_party/abseil-cpp/absl/memory:memory", ] - - if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } } diff --git a/test/pc/e2e/api/BUILD.gn b/test/pc/e2e/api/BUILD.gn index 1159e93534..6371c36acf 100644 --- a/test/pc/e2e/api/BUILD.gn +++ b/test/pc/e2e/api/BUILD.gn @@ -86,9 +86,5 @@ if (rtc_include_tests) { "../:peerconnection_quality_test", "//third_party/abseil-cpp/absl/memory:memory", ] - if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } } } diff --git a/test/scenario/BUILD.gn b/test/scenario/BUILD.gn index 3f168a7e30..e38748d19b 100644 --- a/test/scenario/BUILD.gn +++ b/test/scenario/BUILD.gn @@ -144,9 +144,6 @@ if (rtc_include_tests) { if (rtc_enable_protobuf) { deps += [ "../../modules/audio_coding:ana_config_proto" ] } - if (!build_with_chromium && is_clang) { - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } data = scenario_resources if (is_ios) { deps += [ ":scenario_resources_bundle_data" ] @@ -158,9 +155,6 @@ if (rtc_include_tests) { "scenario_unittest.cc", "video_stream_unittest.cc", ] - if (!build_with_chromium && is_clang) { - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } deps = [ ":scenario", "../../logging:mocks", @@ -183,9 +177,6 @@ if (rtc_include_tests) { sources = [ "quality_stats_unittest.cc", ] - if (!build_with_chromium && is_clang) { - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } deps = [ ":scenario", "../../logging:mocks", diff --git a/test/scenario/network/BUILD.gn b/test/scenario/network/BUILD.gn index 1e33a330bb..3a00d06f9e 100644 --- a/test/scenario/network/BUILD.gn +++ b/test/scenario/network/BUILD.gn @@ -88,11 +88,6 @@ rtc_source_set("network_emulation_pc_unittest") { "../../../test:test_support", "//third_party/abseil-cpp/absl/memory:memory", ] - - if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } } rtc_source_set("cross_traffic_unittest") { diff --git a/test/scenario/scenario_tests/BUILD.gn b/test/scenario/scenario_tests/BUILD.gn index 4f8f769cf3..12d7bc2440 100644 --- a/test/scenario/scenario_tests/BUILD.gn +++ b/test/scenario/scenario_tests/BUILD.gn @@ -26,8 +26,5 @@ if (rtc_include_tests) { "../../../rtc_base/experiments:field_trial_parser", "//testing/gtest", ] - if (!build_with_chromium && is_clang) { - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } } } diff --git a/video/BUILD.gn b/video/BUILD.gn index 8b0caeddfd..6f79875fdd 100644 --- a/video/BUILD.gn +++ b/video/BUILD.gn @@ -48,11 +48,6 @@ rtc_static_library("video") { "video_stream_decoder.h", ] - if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } - deps = [ ":frame_dumping_decoder", "..:webrtc_common", @@ -181,11 +176,6 @@ rtc_source_set("video_stream_encoder_impl") { "video_stream_encoder.h", ] - if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } - deps = [ "../api/units:data_rate", "../api/video:encoded_image", @@ -290,10 +280,6 @@ if (rtc_include_tests) { "../test:video_test_support", "//third_party/abseil-cpp/absl/memory:memory", ] - if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } } rtc_source_set("video_full_stack_tests") { @@ -321,10 +307,6 @@ if (rtc_include_tests) { "//testing/gtest", "//third_party/abseil-cpp/absl/memory", ] - if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } } rtc_executable("video_loopback") { @@ -351,10 +333,6 @@ if (rtc_include_tests) { "//testing/gtest", "//third_party/abseil-cpp/absl/memory", ] - if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } } rtc_executable("screenshare_loopback") { @@ -382,11 +360,6 @@ if (rtc_include_tests) { "//third_party/abseil-cpp/absl/memory", "//third_party/abseil-cpp/absl/types:optional", ] - if (!build_with_chromium && is_clang) { - # Suppress warnings from Chrome's Clang plugins. - # See http://code.google.com/p/webrtc/issues/detail?id=163 for details. - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } } rtc_executable("sv_loopback") { @@ -413,10 +386,6 @@ if (rtc_include_tests) { "//testing/gtest", "//third_party/abseil-cpp/absl/memory", ] - if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } } rtc_executable("video_replay") { @@ -448,10 +417,6 @@ if (rtc_include_tests) { "../test:video_test_support", "//third_party/abseil-cpp/absl/memory", ] - if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } } # TODO(pbos): Rename test suite. @@ -581,10 +546,6 @@ if (rtc_include_tests) { "//third_party/abseil-cpp/absl/memory", "//third_party/abseil-cpp/absl/types:optional", ] - if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } if (!build_with_mozilla) { deps += [ "../media:rtc_media_base" ] } diff --git a/webrtc.gni b/webrtc.gni index d716d7d2d1..61bff0a9fe 100644 --- a/webrtc.gni +++ b/webrtc.gni @@ -286,6 +286,9 @@ rtc_common_inherited_config = webrtc_root + ":common_inherited_config" # Common configs to remove or add in all rtc targets. rtc_remove_configs = [] +if (!build_with_chromium && is_clang) { + rtc_remove_configs += [ "//build/config/clang:find_bad_constructs" ] +} rtc_add_configs = rtc_common_configs rtc_prod_configs = [ webrtc_root + ":rtc_prod_config" ] rtc_library_impl_config = [ webrtc_root + ":library_impl_config" ]