This restricts the interface such that only a single onclose handler can be set and that only one OnClose() notification will be fired. That behavior is the same as how the previous sigslot was being used, but the difference is that, in addition to removing sigslot, this pattern is now more explicitly checked in the design. Bug: webrtc:11943 Change-Id: I469c8cab3d62544988c8145b326af60b06b76d8e Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/343340 Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org> Reviewed-by: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/main@{#41920}
56 lines
1.9 KiB
C++
56 lines
1.9 KiB
C++
/*
|
|
* Copyright 2024 The WebRTC Project Authors. All rights reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#include "p2p/base/packet_transport_internal.h"
|
|
|
|
#include "p2p/base/fake_packet_transport.h"
|
|
#include "rtc_base/gunit.h"
|
|
#include "rtc_base/network/received_packet.h"
|
|
#include "rtc_base/third_party/sigslot/sigslot.h"
|
|
#include "test/gmock.h"
|
|
|
|
namespace {
|
|
|
|
using ::testing::MockFunction;
|
|
|
|
TEST(PacketTransportInternal,
|
|
NotifyPacketReceivedPassthrougPacketToRegisteredListener) {
|
|
rtc::FakePacketTransport packet_transport("test");
|
|
MockFunction<void(rtc::PacketTransportInternal*, const rtc::ReceivedPacket&)>
|
|
receiver;
|
|
|
|
packet_transport.RegisterReceivedPacketCallback(&receiver,
|
|
receiver.AsStdFunction());
|
|
EXPECT_CALL(receiver, Call)
|
|
.WillOnce(
|
|
[](rtc::PacketTransportInternal*, const rtc::ReceivedPacket& packet) {
|
|
EXPECT_EQ(packet.decryption_info(),
|
|
rtc::ReceivedPacket::kDtlsDecrypted);
|
|
});
|
|
packet_transport.NotifyPacketReceived(rtc::ReceivedPacket(
|
|
{}, rtc::SocketAddress(), absl::nullopt, rtc::EcnMarking::kNotEct,
|
|
rtc::ReceivedPacket::kDtlsDecrypted));
|
|
|
|
packet_transport.DeregisterReceivedPacketCallback(&receiver);
|
|
}
|
|
|
|
TEST(PacketTransportInternal, NotifiesOnceOnClose) {
|
|
rtc::FakePacketTransport packet_transport("test");
|
|
int call_count = 0;
|
|
packet_transport.SetOnCloseCallback([&]() { ++call_count; });
|
|
ASSERT_EQ(call_count, 0);
|
|
packet_transport.NotifyOnClose();
|
|
EXPECT_EQ(call_count, 1);
|
|
packet_transport.NotifyOnClose();
|
|
EXPECT_EQ(call_count, 1); // Call count should not have increased.
|
|
}
|
|
|
|
} // namespace
|