admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
webrtc_m130/modules/audio_processing
History
Sam Zackrisson 6558fa5d64 Reintroduce command line controlled reference data updating for ApmTest.Process 
Replaces a hardcoded bool in a test with command line flag.

The current hardcoding of the bool is a little bit hacky. And the
tests will pass automatically, so it is possible to accidentally
commit the flipped bool in a CL, like here:
https://webrtc-review.googlesource.com/c/src/+/150221

I am fairly sure this resolves the vague issue referred to in the attached bug.
The bug is introduced with a TODO here:
https://webrtc-codereview.appspot.com/1728005/diff/4001/webrtc/modules/audio_processing/test/unit_test.cc
Another TODO was added later that refers to the first TODO:
https://webrtc-codereview.appspot.com/6879004/diff/150001/webrtc/modules/audio_processing/test/audio_processing_unittest.cc

Bug: webrtc:1981
Change-Id: I066f41add602c791a5f2ba18829c4306da7dac15
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/150334
Reviewed-by: Per Åhgren <peah@webrtc.org>
Commit-Queue: Sam Zackrisson <saza@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28955}
2019-08-26 11:12:55 +00:00
..
aec
Remove rtc_use_lto GN arg.
2019-08-20 14:00:49 +00:00
aec3
Use the AEC3 high-pass filter for the whole APM
2019-08-23 20:04:10 +00:00
aec_dump
…
aecm
Remove rtc_use_lto GN arg.
2019-08-20 14:00:49 +00:00
agc
Remove rtc_use_lto GN arg.
2019-08-20 14:00:49 +00:00
agc2
…
audio_generator
…
echo_detector
…
include
Use the AEC3 high-pass filter for the whole APM
2019-08-23 20:04:10 +00:00
logging
…
ns
…
test
Reland "Simplification and refactoring of the AudioBuffer code"
2019-08-22 10:34:05 +00:00
transient
…
utility
Use the AEC3 high-pass filter for the whole APM
2019-08-23 20:04:10 +00:00
vad
…
audio_buffer_unittest.cc
Reland "Simplification and refactoring of the AudioBuffer code"
2019-08-22 10:34:05 +00:00
audio_buffer.cc
Correct the handling of sample rates that don't scale well into even 10 ms chunks
2019-08-26 09:54:48 +00:00
audio_buffer.h
Use the AEC3 high-pass filter for the whole APM
2019-08-23 20:04:10 +00:00
audio_frame_view_unittest.cc
Reland "Simplification and refactoring of the AudioBuffer code"
2019-08-22 10:34:05 +00:00
audio_processing_impl_locking_unittest.cc
…
audio_processing_impl_unittest.cc
Use the AEC3 high-pass filter for the whole APM
2019-08-23 20:04:10 +00:00
audio_processing_impl.cc
Use the AEC3 high-pass filter for the whole APM
2019-08-23 20:04:10 +00:00
audio_processing_impl.h
Use the AEC3 high-pass filter for the whole APM
2019-08-23 20:04:10 +00:00
audio_processing_performance_unittest.cc
…
audio_processing_unittest.cc
Reintroduce command line controlled reference data updating for ApmTest.Process
2019-08-26 11:12:55 +00:00
BUILD.gn
Reintroduce command line controlled reference data updating for ApmTest.Process
2019-08-26 11:12:55 +00:00
common.h
…
config_unittest.cc
…
debug.proto
…
DEPS
…
echo_cancellation_bit_exact_unittest.cc
Reland "Simplification and refactoring of the AudioBuffer code"
2019-08-22 10:34:05 +00:00
echo_cancellation_impl_unittest.cc
…
echo_cancellation_impl.cc
Reland "Simplification and refactoring of the AudioBuffer code"
2019-08-22 10:34:05 +00:00
echo_cancellation_impl.h
…
echo_control_mobile_bit_exact_unittest.cc
Reland "Simplification and refactoring of the AudioBuffer code"
2019-08-22 10:34:05 +00:00
echo_control_mobile_impl.cc
Reland "Simplification and refactoring of the AudioBuffer code"
2019-08-22 10:34:05 +00:00
echo_control_mobile_impl.h
…
echo_control_mobile_unittest.cc
…
gain_control_config_proxy_unittest.cc
…
gain_control_config_proxy.cc
…
gain_control_config_proxy.h
…
gain_control_for_experimental_agc.cc
…
gain_control_for_experimental_agc.h
…
gain_control_impl.cc
Reland "Simplification and refactoring of the AudioBuffer code"
2019-08-22 10:34:05 +00:00
gain_control_impl.h
…
gain_control_unittest.cc
Reland "Simplification and refactoring of the AudioBuffer code"
2019-08-22 10:34:05 +00:00
gain_controller2_unittest.cc
Reland "Simplification and refactoring of the AudioBuffer code"
2019-08-22 10:34:05 +00:00
gain_controller2.cc
Reland "Simplification and refactoring of the AudioBuffer code"
2019-08-22 10:34:05 +00:00
gain_controller2.h
…
high_pass_filter_unittest.cc
Use the AEC3 high-pass filter for the whole APM
2019-08-23 20:04:10 +00:00
high_pass_filter.cc
Use the AEC3 high-pass filter for the whole APM
2019-08-23 20:04:10 +00:00
high_pass_filter.h
Use the AEC3 high-pass filter for the whole APM
2019-08-23 20:04:10 +00:00
level_estimator_impl.cc
Reland "Simplification and refactoring of the AudioBuffer code"
2019-08-22 10:34:05 +00:00
level_estimator_impl.h
Reland "Simplification and refactoring of the AudioBuffer code"
2019-08-22 10:34:05 +00:00
level_estimator_unittest.cc
Reland "Simplification and refactoring of the AudioBuffer code"
2019-08-22 10:34:05 +00:00
noise_suppression_impl.cc
Reland "Simplification and refactoring of the AudioBuffer code"
2019-08-22 10:34:05 +00:00
noise_suppression_impl.h
…
noise_suppression_proxy.cc
…
noise_suppression_proxy.h
…
noise_suppression_unittest.cc
Reland "Simplification and refactoring of the AudioBuffer code"
2019-08-22 10:34:05 +00:00
OWNERS
…
render_queue_item_verifier.h
…
residual_echo_detector_unittest.cc
…
residual_echo_detector.cc
Reland "Simplification and refactoring of the AudioBuffer code"
2019-08-22 10:34:05 +00:00
residual_echo_detector.h
…
rms_level_unittest.cc
…
rms_level.cc
…
rms_level.h
…
splitting_filter_unittest.cc
Reland "Simplification and refactoring of the AudioBuffer code"
2019-08-22 10:34:05 +00:00
splitting_filter.cc
Reland "Simplification and refactoring of the AudioBuffer code"
2019-08-22 10:34:05 +00:00
splitting_filter.h
Reland "Simplification and refactoring of the AudioBuffer code"
2019-08-22 10:34:05 +00:00
three_band_filter_bank.cc
…
three_band_filter_bank.h
…
typing_detection.cc
…
typing_detection.h
…
voice_detection_impl.cc
Reland "Simplification and refactoring of the AudioBuffer code"
2019-08-22 10:34:05 +00:00
voice_detection_impl.h
…
voice_detection_unittest.cc
Reland "Simplification and refactoring of the AudioBuffer code"
2019-08-22 10:34:05 +00:00